add more extension functions for dynamic-links-ktx

[thatfiredev]

KTX Suggestions

1. Extension functions for Intent and Uri

This allows developers to use intent.getFirebaseDynamicLink() and uri.getFirebaseDynamicLink() instead of Firebase.dynamicLinks.getDynamicLink(intent).

This was removed from the PR. See discussion below.

2. Destructuring declarations for ShortDynamicLink and PendingDynamicLinkData

ShortDynamicLink

val shortLinkTask = Firebase.dynamicLinks.shortLinkAsync {
    longLink = Uri.parse("https://example.page.link/?ibn=com.example.android")
}.addOnSuccessListener { result ->
    val shortLink = result.shortLink
    val flowchartLink = result.previewLink
    // use the received values
}

becomes:

val shortLinkTask = Firebase.dynamicLinks.shortLinkAsync {
    longLink = Uri.parse("https://example.page.link/?ibn=com.example.android")
}.addOnSuccessListener { (shortLink, previewLink, warnings) ->
    // access values directly
}

PendingDynamicLinkData

Firebase.dynamicLinks
        .getDynamicLink(intent)
        .addOnSuccessListener(this) { pendingDynamicLinkData ->
            val deepLink = pendingDynamicLinkData.link
            val minAppVersion = pendingDynamicLinkData.minimumAppVersion
            val clickTimestamp = pendingDynamicLinkData.clickTimestamp
            // use the received values
        }

becomes:

Firebase.dynamicLinks
        .getDynamicLink(intent)
        .addOnSuccessListener(this) { (deepLink, minAppVersion, clickTimestamp) ->
            // access the values directly
        }

[google-oss-bot]

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rlazo]

Hi @rosariopfernandes thanks for your proposal! I like the idea of the destructuring, but I'm not entirely sure about the extensions for Intent and Uri.

@vkryachko wdyt?

[rlazo]

/ok-to-test

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-dynamic-links-ktx

  SDK overall coverage changed from 77.78% (739dd16) to 80.39% (2ed4677d) by +2.61%.

  Filename	Base (739dd16)	Head (2ed4677d)	Diff
  FirebaseDynamicLinks.kt	77.78%	80.39%	+2.61%

Test Logs

• Base (739dd164): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1291449098364260354
• Head (2ed4677d): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1753/check-coverage-changed/1292844165066919936

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (2ed4677d) is created by Prow via merging commits: 739dd16 9b84fd3.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-dynamic-links-ktx

  Type	Base (739dd16)	Head (2ed4677d)	Diff
  aar	8.01 kB	8.54 kB	+526 B (+6.6%)
  apk (release)	1.41 MB	1.41 MB	+96 B (+0.0%)

Test Logs

• Base (739dd164): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1291449098355871744
• Head (2ed4677d): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1753/binary-size/1292844165066919939

Notes

Head commit (2ed4677d) is created by Prow via merging commits: 739dd16 9b84fd3.

[rlazo]

Check-changed failed because

> Task :firebase-dynamic-links:ktx:ktlintMainSourceSetCheck
�[90m/home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-dynamic-links/ktx/src/main/kotlin/com/google/firebase/dynamiclinks/ktx/�[0mFirebaseDynamicLinks.kt�[90m:�[0m17�[90m:1:�[0m Unused import
"plain" report written to /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-dynamic-links/ktx/build/reports/ktlint/ktlintMainSourceSetCheck.txt
�[90m/home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-dynamic-links/ktx/src/main/kotlin/com/google/firebase/dynamiclinks/ktx/�[0mFirebaseDynamicLinks.kt�[90m:�[0m18�[90m:1:�[0m Unused import

you can use ./gradlew firebase-dynamic-links:ktx:klintFormat to format the code (this is new).

[thatfiredev]

@rlazo done, thanks!
I also went ahead and added tests for it.

[rlazo]

Thanks @rosariopfernandes ! I'll get your proposal through the API review and let you know the result.

[rlazo]

Hi @rosariopfernandes thanks for your patience, your proposal has been approved 👍 Just address the comments below and we can merge your change. Thanks for your help!

[thatfiredev]

Thanks @rlazo ! All done.

[rlazo]

Thanks!

[google-oss-bot]

@rosariopfernandes: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
smoke-tests	9b84fd3	link	/test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.