Skip to content

Move firebase messaging and directboot to github #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

Move firebase messaging and directboot to github #1792

merged 1 commit into from
Jul 21, 2020

Conversation

VinayGuthal
Copy link
Contributor

@VinayGuthal VinayGuthal commented Jul 20, 2020 •
edited
Loading

Open source firebase messaging and directboot.

@googlebot googlebot added the cla: yes Override cla label Jul 20, 2020
@VinayGuthal VinayGuthal changed the title Update firebase messaging Move firebase messaging and directboot to github Jul 20, 2020
@VinayGuthal VinayGuthal mentioned this pull request Jul 20, 2020
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 20, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.26% (3f4b32d) to 51.20% (59ccfc39) by -0.06%.

    Filename Base (3f4b32d) Head (59ccfc39) Diff
    ChildChangeAccumulator.java 96.77% 83.87% -12.90%
    ViewProcessor.java 92.35% 92.05% -0.31%

  • firebase-messaging

    SDK overall coverage changed from ? (3f4b32d) to 83.92% (59ccfc39) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (3f4b32d) Head (59ccfc39) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 66.67% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 90.48% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 66.29% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 98.67% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (59ccfc39) is created by Prow via merging commits: 3f4b32d 00cf720.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 20, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-crashlytics-ndk

    Type Base (3f4b32d) Head (59ccfc39) Diff
    apk (debug) 2.76 MB 2.76 MB -4.10 kB (-0.1%)

  • firebase-functions

    Type Base (3f4b32d) Head (59ccfc39) Diff
    apk (debug) 1.37 MB 1.37 MB +1 B (+0.0%)

  • firebase-messaging

    Type Base (3f4b32d) Head (59ccfc39) Diff
    aar ? 174 kB ? (?)
    apk (aggressive) ? 493 kB ? (?)
    apk (debug) ? 2.97 MB ? (?)
    apk (release) ? 2.43 MB ? (?)

  • firebase-messaging-directboot

    Type Base (3f4b32d) Head (59ccfc39) Diff
    aar ? 10.4 kB ? (?)
    apk (aggressive) ? 408 kB ? (?)
    apk (debug) ? 2.85 MB ? (?)
    apk (release) ? 2.31 MB ? (?)

  • firebase-storage-ktx

    Type Base (3f4b32d) Head (59ccfc39) Diff
    apk (debug) 1.75 MB 1.75 MB -2 B (-0.0%)

  • transport-runtime

    Type Base (3f4b32d) Head (59ccfc39) Diff
    apk (debug) 82.5 kB 82.5 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (59ccfc39) is created by Prow via merging commits: 3f4b32d 00cf720.

@VinayGuthal
Copy link
Contributor Author

/retest

ciarand
ciarand approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@ciarand ciarand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, the start of a new era

@VinayGuthal VinayGuthal merged commit fe51be9 into master Jul 21, 2020
@VinayGuthal VinayGuthal deleted the move_messaging branch July 21, 2020 18:35
@firebase firebase locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwinraghav ashwinraghav ashwinraghav approved these changes

@ciarand ciarand ciarand approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VinayGuthal @google-oss-bot @ashwinraghav @ciarand @googlebot