Skip to content

open source fcm and fcm direct boot #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jul 16, 2020
@VinayGuthal VinayGuthal requested review from ciarand and vkryachko July 16, 2020 19:43
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-components

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 35.2 kB 35.2 kB +2 B (+0.0%)
  • firebase-config-ktx

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 1.87 MB 1.87 MB -1 B (-0.0%)
  • firebase-crashlytics

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 1.28 MB 1.28 MB -2 B (-0.0%)
  • firebase-datatransport

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 856 kB 856 kB -3 B (-0.0%)
  • firebase-dynamic-links

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 1.10 MB 1.10 MB -2 B (-0.0%)
  • firebase-installations

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    aar 59.2 kB 59.2 kB +4 B (+0.0%)
  • firebase-installations-interop

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 748 kB 748 kB -1 B (-0.0%)
  • firebase-messaging

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    aar ? 174 kB ? (?)
    apk (aggressive) ? 493 kB ? (?)
    apk (debug) ? 2.97 MB ? (?)
    apk (release) ? 2.43 MB ? (?)
  • firebase-messaging-directboot

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    aar ? 10.4 kB ? (?)
    apk (aggressive) ? 408 kB ? (?)
    apk (debug) ? 2.85 MB ? (?)
    apk (release) ? 2.31 MB ? (?)
  • transport-runtime

    Type Base (37dd2b1) Head (5d4db9b6) Diff
    apk (debug) 82.5 kB 82.5 kB +1 B (+0.0%)

Test Logs

Notes

Head commit (5d4db9b6) is created by Prow via merging commits: 37dd2b1 094286c.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage did not change between base commit (37dd2b1) and head commit (5d4db9b6). However there are changes in individual files.

    Filename Base (37dd2b1) Head (5d4db9b6) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ViewProcessor.java 92.35% 92.05% -0.31%
  • firebase-messaging

    SDK overall coverage changed from ? (37dd2b1) to 84.06% (5d4db9b6) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (37dd2b1) Head (5d4db9b6) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 66.67% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 90.48% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 66.29% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 98.67% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 91.38% ?
    TopicsSyncTask.java ? 53.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (5d4db9b6) is created by Prow via merging commits: 37dd2b1 094286c.

@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 094286c link /test api-information
device-check-changed 094286c link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ashwinraghav
Copy link
Contributor

Good to ship once CI is green

@VinayGuthal
Copy link
Contributor Author

Closed in favour of #1792

@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
@vkryachko vkryachko deleted the move_messaging_directboot branch December 2, 2022 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants