Skip to content

Fix dependents task. #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2020
Merged

Fix dependents task. #1549

merged 4 commits into from
May 12, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from ashwinraghav May 11, 2020 21:57
@googlebot googlebot added the cla: yes Override cla label May 11, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.19% (41505a7) to 51.16% (5c9053b9) by -0.03%.

    Filename Base (41505a7) Head (5c9053b9) Diff
    ChildChangeAccumulator.java 96.77% 83.87% -12.90%
    ViewProcessor.java 92.05% 92.35% +0.31%

  • firebase-inappmessaging-display-ktx

    SDK overall coverage changed from ? (41505a7) to 100.00% (5c9053b9) by ?.

    Filename Base (41505a7) Head (5c9053b9) Diff
    InAppMessagingDisplay.kt ? 100.00% ?

  • firebase-inappmessaging-ktx

    SDK overall coverage changed from ? (41505a7) to 100.00% (5c9053b9) by ?.

    Filename Base (41505a7) Head (5c9053b9) Diff
    InAppMessaging.kt ? 100.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (5c9053b9) is created by Prow via merging commits: 41505a7 53377e2.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 11, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (debug) 894 kB 894 kB +26 B (+0.0%)

  • firebase-common

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 82.5 kB 82.5 kB -7 B (-0.0%)
    apk (debug) 770 kB 770 kB +11 B (+0.0%)

  • firebase-common-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (debug) 1.56 MB 1.56 MB -31 B (-0.0%)

  • firebase-components

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 11.0 kB 10.9 kB -14 B (-0.1%)
    apk (debug) 35.9 kB 35.8 kB -25 B (-0.1%)

  • firebase-config

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (debug) 1.34 MB 1.34 MB +44 B (+0.0%)

  • firebase-config-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 593 kB 593 kB -15 B (-0.0%)
    apk (debug) 2.13 MB 2.13 MB -63 B (-0.0%)

  • firebase-crashlytics

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 598 kB 598 kB -7 B (-0.0%)
    apk (debug) 1.60 MB 1.60 MB +21 B (+0.0%)

  • firebase-crashlytics-ndk

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 1.19 MB 1.19 MB -14 B (-0.0%)
    apk (debug) 2.23 MB 2.23 MB -23 B (-0.0%)

  • firebase-database

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (debug) 1.29 MB 1.29 MB +34 B (+0.0%)

  • firebase-database-collection

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 314 kB 314 kB -1 B (-0.0%)
    apk (debug) 1.07 MB 1.07 MB -1 B (-0.0%)

  • firebase-database-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 515 kB 515 kB -7 B (-0.0%)
    apk (debug) 2.08 MB 2.08 MB +158 B (+0.0%)

  • firebase-datatransport

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 117 kB 117 kB +15 B (+0.0%)
    apk (debug) 846 kB 846 kB +22 B (+0.0%)

  • firebase-dynamic-links

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 327 kB 327 kB -15 B (-0.0%)
    apk (debug) 1.10 MB 1.10 MB -57 B (-0.0%)

  • firebase-dynamic-links-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 517 kB 517 kB +11 B (+0.0%)
    apk (debug) 1.89 MB 1.89 MB +90 B (+0.0%)

  • firebase-encoders-json

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 11.0 kB 10.9 kB -14 B (-0.1%)
    apk (debug) 27.4 kB 27.4 kB -2 B (-0.0%)

  • firebase-encoders-reflective

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 11.0 kB 10.9 kB -14 B (-0.1%)
    apk (debug) 30.0 kB 30.0 kB -2 B (-0.0%)

  • firebase-firestore

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 443 kB 443 kB +1 B (+0.0%)
    apk (debug) 3.74 MB 3.74 MB -34 B (-0.0%)

  • firebase-firestore-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 633 kB 633 kB +10 B (+0.0%)
    apk (debug) 4.53 MB 4.53 MB -44 B (-0.0%)

  • firebase-functions

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (debug) 1.37 MB 1.37 MB +24 B (+0.0%)

  • firebase-functions-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 583 kB 583 kB +17 B (+0.0%)
    apk (debug) 2.16 MB 2.16 MB +82 B (+0.0%)

  • firebase-inappmessaging

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 610 kB 610 kB +7 B (+0.0%)
    apk (debug) 4.01 MB 4.01 MB -21 B (-0.0%)

  • firebase-inappmessaging-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 800 kB 800 kB -14 B (-0.0%)
    apk (debug) 4.81 MB 4.81 MB -9 B (-0.0%)

  • firebase-installations

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 84.3 kB 84.3 kB -2 B (-0.0%)
    apk (debug) 794 kB 794 kB +16 B (+0.0%)

  • firebase-installations-interop

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 61.7 kB 61.7 kB +7 B (+0.0%)
    apk (debug) 744 kB 744 kB +61 B (+0.0%)

  • firebase-segmentation

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 802 kB 802 kB -4 B (-0.0%)
    apk (debug) 1.61 MB 1.61 MB +87 B (+0.0%)

  • firebase-storage

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 326 kB 326 kB -6 B (-0.0%)
    apk (debug) 1.13 MB 1.13 MB +140 B (+0.0%)

  • firebase-storage-ktx

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 515 kB 515 kB -1 B (-0.0%)
    apk (debug) 1.92 MB 1.92 MB -103 B (-0.0%)

  • protolite-well-known-types

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 122 kB 122 kB -14 B (-0.0%)
    apk (debug) 643 kB 643 kB +1 B (+0.0%)

  • transport-api

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 11.0 kB 10.9 kB -14 B (-0.1%)
    apk (debug) 23.0 kB 23.0 kB -1 B (-0.0%)

  • transport-backend-cct

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 47.9 kB 47.9 kB -6 B (-0.0%)
    apk (debug) 101 kB 101 kB -24 B (-0.0%)

  • transport-runtime

    Type Base (41505a7) Head (5c9053b9) Diff
    apk (aggressive) 35.6 kB 35.6 kB +3 B (+0.0%)
    apk (debug) 80.5 kB 80.5 kB -2 B (-0.0%)

Test Logs

Notes

Head commit (5c9053b9) is created by Prow via merging commits: 41505a7 53377e2.

@vkryachko
Copy link
Member Author

/retest

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 53377e2 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit fc2b6f3 into master May 12, 2020
ashwinraghav pushed a commit that referenced this pull request May 18, 2020
@vkryachko @ashwinraghav
Fix dependents task. (#1549)
db1d381 
* Fix dependents task.

* Fix fis-related test failures.

* Fix app FTL runs.
@firebase firebase locked and limited conversation to collaborators Jun 12, 2020
@vkryachko vkryachko deleted the vk.cifix branch October 20, 2020 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwinraghav ashwinraghav ashwinraghav approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @ashwinraghav @googlebot