Skip to content

Commit fc2b6f3

Browse files
authored
Fix dependents task. (#1549)
* Fix dependents task. * Fix fis-related test failures. * Fix app FTL runs.
1 parent 41505a7 commit fc2b6f3

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ci/ContinuousIntegrationPlugin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void apply(Project project) {
3939
Task connectedCheckDependents = sub.task("connectedCheckDependents");
4040
Task deviceCheckDependents = sub.task("deviceCheckDependents");
4141

42-
project
42+
sub
4343
.getConfigurations()
4444
.all(
4545
cfg -> {

buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ci/device/FirebaseTestServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public void uploadApks(String variantName, File testApk, File testedApk) {
4646
// test lab requires an "app" apk, so we give an empty apk to it.
4747
String testedApkPath =
4848
testedApk != null
49-
? testApk.toString()
49+
? testedApk.toString()
5050
: project.getRootDir() + "/buildSrc/resources/dummy.apk";
5151
project
5252
.getLogger()

firebase-inappmessaging-display/ktx/src/test/kotlin/com/google/firebase/inappmessaging/display/ktx/InAppMessagingDisplayTests.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ import org.junit.Test
2828
import org.junit.runner.RunWith
2929
import org.robolectric.RobolectricTestRunner
3030
import org.robolectric.RuntimeEnvironment
31+
import java.util.UUID
3132

32-
const val APP_ID = "APP_ID"
33-
const val API_KEY = "API_KEY"
33+
internal const val APP_ID = "APP:ID"
34+
internal val API_KEY = "ABC" + UUID.randomUUID().toString()
3435

3536
const val EXISTING_APP = "existing"
3637

firebase-inappmessaging/ktx/src/test/kotlin/com/google/firebase/inappmessagging/ktx/InAppMessaggingTests.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ import org.junit.Test
2828
import org.junit.runner.RunWith
2929
import org.robolectric.RobolectricTestRunner
3030
import org.robolectric.RuntimeEnvironment
31+
import java.util.UUID
3132

32-
const val APP_ID = "APP_ID"
33-
const val API_KEY = "API_KEY"
33+
internal const val APP_ID = "APP:ID"
34+
internal val API_KEY = "ABC" + UUID.randomUUID().toString()
3435

3536
const val EXISTING_APP = "existing"
3637

0 commit comments

Comments
 (0)