Skip to content

Fix @AutoValue-related proguard issues. #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

Fix @AutoValue-related proguard issues. #1472

merged 1 commit into from
Apr 16, 2020

Conversation

vkryachko
Copy link
Member

@vkryachko vkryachko commented Apr 16, 2020 •
edited
Loading

Fixes #317

@vkryachko vkryachko requested a review from ashwinraghav April 16, 2020 02:01
@googlebot googlebot added the cla: yes Override cla label Apr 16, 2020
@vkryachko vkryachko requested a review from VinayGuthal April 16, 2020 02:01
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 16, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • base

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 10.7 kB 10.7 kB +15 B (+0.1%)

  • firebase-abt

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 85.6 kB 85.6 kB -14 B (-0.0%)
    apk (release) 747 kB 746 kB -395 B (-0.1%)

  • firebase-common

    Type Base (26cc04d) Head (856f1ca) Diff
    aar 34.6 kB 34.7 kB +27 B (+0.1%)
    apk (aggressive) 82.9 kB 82.9 kB -14 B (-0.0%)
    apk (release) 647 kB 647 kB -247 B (-0.0%)

  • firebase-components

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 10.9 kB 11.0 kB +11 B (+0.1%)

  • firebase-config

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 403 kB 403 kB +6 B (+0.0%)
    apk (release) 1.16 MB 1.16 MB -438 B (-0.0%)

  • firebase-crashlytics

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (release) 1.37 MB 1.37 MB -320 B (-0.0%)

  • firebase-crashlytics-ndk

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (release) 1.96 MB 1.96 MB -395 B (-0.0%)

  • firebase-database

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 326 kB 326 kB -7 B (-0.0%)
    apk (release) 1.10 MB 1.10 MB -214 B (-0.0%)

  • firebase-datatransport

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 117 kB 117 kB -15 B (-0.0%)
    apk (release) 713 kB 713 kB -275 B (-0.0%)

  • firebase-dynamic-links

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 328 kB 328 kB -7 B (-0.0%)
    apk (release) 952 kB 951 kB -298 B (-0.0%)

  • firebase-firestore

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 443 kB 443 kB -21 B (-0.0%)
    apk (release) 3.14 MB 3.14 MB -199 B (-0.0%)

  • firebase-functions

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 394 kB 394 kB -4 B (-0.0%)
    apk (release) 1.18 MB 1.18 MB -409 B (-0.0%)

  • firebase-inappmessaging-display

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 1.82 MB 1.82 MB +3 B (+0.0%)

  • firebase-installations

    Type Base (26cc04d) Head (856f1ca) Diff
    aar 57.5 kB 57.5 kB -5 B (-0.0%)
    apk (release) 666 kB 666 kB -51 B (-0.0%)

  • firebase-installations-interop

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 61.7 kB 61.7 kB -6 B (-0.0%)

  • firebase-segmentation

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 802 kB 802 kB +10 B (+0.0%)
    apk (release) 1.39 MB 1.39 MB -313 B (-0.0%)

  • firebase-storage

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (release) 977 kB 977 kB -491 B (-0.1%)

  • protolite-well-known-types

    Type Base (26cc04d) Head (856f1ca) Diff
    apk (aggressive) 122 kB 122 kB -17 B (-0.0%)

  • transport:transport-api

    Type Base (26cc04d) Head (856f1ca) Diff
    aar 6.44 kB 6.59 kB +153 B (+2.4%)

  • transport:transport-backend-cct

    Type Base (26cc04d) Head (856f1ca) Diff
    aar 38.8 kB 39.0 kB +153 B (+0.4%)

  • transport:transport-runtime

    Type Base (26cc04d) Head (856f1ca) Diff
    aar 126 kB 126 kB +153 B (+0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 16, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage did not change between base commit (26cc04d) and head commit (856f1ca). However there are changes in individual files.

    Filename Base (26cc04d) Head (856f1ca) Diff
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    ViewProcessor.java 92.35% 92.05% -0.31%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

@vkryachko vkryachko force-pushed the vk.autovalue_fixes branch from 68b63bc to 856f1ca Compare April 16, 2020 14:59
@vkryachko vkryachko changed the title Upgrade to latest autovalue and expose it in maven deps. Fix @AutoValue-related proguard issues. Apr 16, 2020
@vkryachko vkryachko merged commit 037e096 into master Apr 16, 2020
@vkryachko vkryachko mentioned this pull request Apr 20, 2020
Closed
@vkryachko vkryachko deleted the vk.autovalue_fixes branch April 21, 2020 15:28
kmayoral
kmayoral reviewed May 7, 2020
View reviewed changes
firebase-common/firebase-common.gradle
@@ -66,7 +66,7 @@ dependencies {
implementation 'com.google.android.gms:play-services-basement:17.0.0'
implementation "com.google.android.gms:play-services-tasks:17.0.0"

api 'com.google.auto.value:auto-value-annotations:1.6.5'
compileOnly 'com.google.auto.value:auto-value-annotations:1.6.6'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you can't just go to 1.7.1 here?

kmayoral
kmayoral reviewed May 7, 2020
View reviewed changes
firebase-common/firebase-common.gradle
@@ -79,7 +79,7 @@ dependencies {
testImplementation "com.google.truth:truth:$googleTruthVersion"
testImplementation 'org.mockito:mockito-core:2.25.0'

annotationProcessor 'com.google.auto.value:auto-value:1.6.2'
annotationProcessor 'com.google.auto.value:auto-value:1.6.5'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this, going to 1.7.1 as the latest

@firebase firebase locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmayoral kmayoral kmayoral left review comments

@ashwinraghav ashwinraghav ashwinraghav approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase-common: version conflict with auto-value-annotations
5 participants
@vkryachko @google-oss-bot @ashwinraghav @kmayoral @googlebot