Skip to content

Remove auto-value-annotation dependency from firebase-common #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samtstern opened this issue Jul 17, 2019 · 2 comments
Closed

Remove auto-value-annotation dependency from firebase-common #625

samtstern opened this issue Jul 17, 2019 · 2 comments
Assignees

Comments

@samtstern
Copy link
Contributor

samtstern commented Jul 17, 2019

[READ] Step 1: Are you in the right place?

Yes.

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: any
  • Firebase Component: common
  • Component version: 18.0.0.

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

If you look at https://dl.google.com/dl/android/maven2/com/google/firebase/firebase-common/18.0.0/firebase-common-18.0.0.pom

You can see this dependency:

    <dependency>
      <groupId>com.google.auto.value</groupId>
      <artifactId>auto-value-annotations</artifactId>
      <version>1.6.3</version>
      <scope>compile</scope>
      <type>jar</type>
    </dependency>

This adds a new dependency (a 5kB JAR so not a big one) to every app that uses Firebase:
https://mvnrepository.com/artifact/com.google.auto.value/auto-value-annotations/1.6.3'

I believe it also causes issues with apps that are using auto-value at a different version than we are:
google/auto#620

We only use this dependency inside common in one place:
https://github.com/firebase/firebase-android-sdk/blob/master/firebase-common/src/main/java/com/google/firebase/platforminfo/LibraryVersion.java

We would probably be better off just hand-writing the value class and dropping the dep.

Relevant Code:

N/A

@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@vkryachko
Copy link
Member

Fixed by #1472

@firebase firebase locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants