We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yes.
If you look at https://dl.google.com/dl/android/maven2/com/google/firebase/firebase-common/18.0.0/firebase-common-18.0.0.pom
You can see this dependency:
<dependency> <groupId>com.google.auto.value</groupId> <artifactId>auto-value-annotations</artifactId> <version>1.6.3</version> <scope>compile</scope> <type>jar</type> </dependency>
This adds a new dependency (a 5kB JAR so not a big one) to every app that uses Firebase: https://mvnrepository.com/artifact/com.google.auto.value/auto-value-annotations/1.6.3'
I believe it also causes issues with apps that are using auto-value at a different version than we are: google/auto#620
We only use this dependency inside common in one place: https://github.com/firebase/firebase-android-sdk/blob/master/firebase-common/src/main/java/com/google/firebase/platforminfo/LibraryVersion.java
common
We would probably be better off just hand-writing the value class and dropping the dep.
N/A
The text was updated successfully, but these errors were encountered:
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
Sorry, something went wrong.
Fixed by #1472
ashwinraghav
No branches or pull requests
Uh oh!
There was an error while loading. Please reload this page.
[READ] Step 1: Are you in the right place?
Yes.
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
If you look at https://dl.google.com/dl/android/maven2/com/google/firebase/firebase-common/18.0.0/firebase-common-18.0.0.pom
You can see this dependency:
This adds a new dependency (a 5kB JAR so not a big one) to every app that uses Firebase:
https://mvnrepository.com/artifact/com.google.auto.value/auto-value-annotations/1.6.3'
I believe it also causes issues with apps that are using auto-value at a different version than we are:
google/auto#620
We only use this dependency inside
common
in one place:https://github.com/firebase/firebase-android-sdk/blob/master/firebase-common/src/main/java/com/google/firebase/platforminfo/LibraryVersion.java
We would probably be better off just hand-writing the value class and dropping the dep.
Relevant Code:
N/A
The text was updated successfully, but these errors were encountered: