Enable errorprone only by request. #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation is that errorprone produces different bytecode than javac this confuses retrolambda's desugaring where it fails to correctly desugar try-with-resources. To enable errorprone one needs to run: ``` ./gradlew :mylib:mytask withErrorProne ```
vkryachko
force-pushed
the
vk.disable_errorprone
branch
from
57f08d5 to
8f529e4
Compare
Binary Size ReportAffected SDKs
Test Logs |
vkryachko
force-pushed
the
vk.disable_errorprone
branch
from
6cee852 to
aa631d4
Compare
|
/retest |
vkryachko
force-pushed
the
vk.disable_errorprone
branch
from
9bd4ef4 to
aa631d4
Compare
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with |
|
/test smoke-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is that errorprone produces different bytecode than javac
this confuses retrolambda's desugaring where it fails to correctly
desugar try-with-resources.
To enable errorprone one needs to run: