Removing try-with-resources (#1458)

* Dropping guava and appcompat dependency from FIS SDK.

* Removing try-with-resources

* Fix for Rayo's comments

Author: ankitaj224

firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

@@ -148,14 +148,14 @@ private void preConditionChecks() {
     Preconditions.checkNotEmpty(getApiKey());
     Preconditions.checkArgument(
         Utils.isValidAppIdFormat(getApplicationId()),
-            "Please set your Application ID. A valid Firebase App ID is required to communicate "
-                    + "with Firebase server APIs: It identifies your application with Firebase."
-                    + "Please refer to https://firebase.google.com/support/privacy/init-options.");
+        "Please set your Application ID. A valid Firebase App ID is required to communicate "
+            + "with Firebase server APIs: It identifies your application with Firebase."
+            + "Please refer to https://firebase.google.com/support/privacy/init-options.");
     Preconditions.checkArgument(
         Utils.isValidApiKeyFormat(getApiKey()),
-            "Please set a valid API key. A Firebase API key is required to communicate with "
-                    + "Firebase server APIs: It authenticates your project with Google."
-                    + "Please refer to https://firebase.google.com/support/privacy/init-options.");
+        "Please set a valid API key. A Firebase API key is required to communicate with "
+            + "Firebase server APIs: It authenticates your project with Google."
+            + "Please refer to https://firebase.google.com/support/privacy/init-options.");
   }
 
   /** Returns the Project Id or Project Number for the Firebase Project. */

firebase-installations/src/main/java/com/google/firebase/installations/Utils.java

@@ -15,9 +15,7 @@
 package com.google.firebase.installations;
 
 import android.text.TextUtils;
-
 import androidx.annotation.Nullable;
-
 import com.google.firebase.installations.local.PersistedInstallationEntry;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Pattern;

firebase-installations/src/main/java/com/google/firebase/installations/remote/FirebaseInstallationServiceClient.java

@@ -205,12 +205,19 @@ private static byte[] getJsonBytes(JSONObject jsonObject) throws IOException {
 
   private static void writeRequestBodyToOutputStream(URLConnection urlConnection, byte[] jsonBytes)
       throws IOException {
-    try (OutputStream outputStream = urlConnection.getOutputStream()) {
-      if (outputStream == null) {
-        throw new IOException("Cannot send request to FIS servers. No OutputStream available.");
-      }
-      try (GZIPOutputStream gzipOutputStream = new GZIPOutputStream(outputStream)) {
-        gzipOutputStream.write(jsonBytes);
+    OutputStream outputStream = urlConnection.getOutputStream();
+    if (outputStream == null) {
+      throw new IOException("Cannot send request to FIS servers. No OutputStream available.");
+    }
+    GZIPOutputStream gzipOutputStream = new GZIPOutputStream(outputStream);
+    try {
+      gzipOutputStream.write(jsonBytes);
+    } finally {
+      try {
+        gzipOutputStream.close();
+        outputStream.close();
+      } catch (IOException ignored) {
+
       }
     }
   }
@@ -525,8 +532,12 @@ private static void logFisCommunicationError(HttpURLConnection conn) {
   // Read the error message from the response.
   @Nullable
   private static String readErrorResponse(HttpURLConnection conn) {
-    try (BufferedReader reader =
-        new BufferedReader(new InputStreamReader(conn.getErrorStream(), UTF_8))) {
+    InputStream errorStream = conn.getErrorStream();
+    if (errorStream == null) {
+      return null;
+    }
+    BufferedReader reader = new BufferedReader(new InputStreamReader(errorStream, UTF_8));
+    try {
       StringBuilder response = new StringBuilder();
       for (String input = reader.readLine(); input != null; input = reader.readLine()) {
         response.append(input).append('\n');
@@ -536,6 +547,12 @@ private static String readErrorResponse(HttpURLConnection conn) {
           conn.getResponseCode(), conn.getResponseMessage(), response);
     } catch (IOException ignored) {
       return null;
+    } finally {
+      try {
+        reader.close();
+      } catch (IOException ignored) {
+
+      }
     }
   }
 }

firebase-installations/src/test/java/com/google/firebase/installations/FirebaseInstallationsTest.java

@@ -1001,8 +1001,8 @@ public void testApiKeyCheck() {
     assertFalse(Utils.isValidApiKeyFormat("AIzaSyabcdefghijklmno qrstuvwxyzabcdefg")); // wrong char
     assertFalse(
         Utils.isValidApiKeyFormat(
-                "AAAAdpB7anM:APA91bFFK03DIT8y3l5uymwbKcUDJdYqTRSP9Qcxg8SU5kKPalEpObdx0C0xv8gQttdWlL"
-                        + "W4hLvvHA0JoDKA6Lrvbi-edUjFCPY_WJkuvHxFwGWXjnj4yI4sPQ27mXuSVIyAbgX4aTK0QY"
-                        + "pIKq2j1NBi7ZU75gunQg")); // using FCM server key as API key.
+            "AAAAdpB7anM:APA91bFFK03DIT8y3l5uymwbKcUDJdYqTRSP9Qcxg8SU5kKPalEpObdx0C0xv8gQttdWlL"
+                + "W4hLvvHA0JoDKA6Lrvbi-edUjFCPY_WJkuvHxFwGWXjnj4yI4sPQ27mXuSVIyAbgX4aTK0QY"
+                + "pIKq2j1NBi7ZU75gunQg")); // using FCM server key as API key.
   }
 }