Remove hard limit on Crashlytics payload size (#1439)

DataTransport SDK will support larger payloads going forward, and
we will continue to iterate on more precise changes to reduce
payload sizes in the future.

Author: mrwillis21

firebase-crashlytics/src/androidTest/java/com/google/firebase/crashlytics/internal/send/DataTransportCrashlyticsReportSenderTest.java

@@ -20,8 +20,6 @@
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 import androidx.test.runner.AndroidJUnit4;
@@ -129,26 +127,6 @@ public void testSendReports_oneSuccessOneFail() throws Exception {
     assertEquals(ex, send2.getException());
   }
 
-  @Test
-  public void testSendLargeReport_successfulWithoutSchedulingToDataTransport() throws Exception {
-    doAnswer(callbackAnswer(null)).when(mockTransport).schedule(any(), any());
-
-    final CrashlyticsReportWithSessionId report = mockReportWithSessionId();
-
-    when(mockTransform.apply(report.getReport())).thenReturn(new byte[1024 * 1024]);
-
-    final Task<CrashlyticsReportWithSessionId> send = reportSender.sendReport(report);
-
-    try {
-      Tasks.await(send);
-    } catch (ExecutionException e) {
-      // Allow this to fall through
-    }
-
-    assertTrue(send.isSuccessful());
-    verify(mockTransport, never()).schedule(any(), any());
-  }
-
   private static Answer<Void> callbackAnswer(Exception failure) {
     return (i) -> {
       final TransportScheduleCallback callback = i.getArgument(1);

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/send/DataTransportCrashlyticsReportSender.java

@@ -24,8 +24,6 @@
 import com.google.android.datatransport.runtime.TransportRuntime;
 import com.google.android.gms.tasks.Task;
 import com.google.android.gms.tasks.TaskCompletionSource;
-import com.google.android.gms.tasks.Tasks;
-import com.google.firebase.crashlytics.internal.Logger;
 import com.google.firebase.crashlytics.internal.common.CrashlyticsReportWithSessionId;
 import com.google.firebase.crashlytics.internal.model.CrashlyticsReport;
 import com.google.firebase.crashlytics.internal.model.serialization.CrashlyticsReportJsonTransform;
@@ -47,9 +45,6 @@ public class DataTransportCrashlyticsReportSender {
   private static final Transformer<CrashlyticsReport, byte[]> DEFAULT_TRANSFORM =
       (r) -> TRANSFORM.reportToJson(r).getBytes(Charset.forName("UTF-8"));
 
-  // Assumed limit of 1MB, with a little extra headroom
-  private static final int MAX_DATATRANSPORT_BYTES = 1024 * 832;
-
   private final Transport<CrashlyticsReport> transport;
   private final Transformer<CrashlyticsReport, byte[]> transportTransform;
 
@@ -78,17 +73,6 @@ public Task<CrashlyticsReportWithSessionId> sendReport(
       @NonNull CrashlyticsReportWithSessionId reportWithSessionId) {
     final CrashlyticsReport report = reportWithSessionId.getReport();
 
-    // Workaround for b/152905875, impose a maximum size on reports.
-    final int reportSize = transportTransform.apply(report).length;
-    if (reportSize > MAX_DATATRANSPORT_BYTES) {
-      Logger.getLogger()
-          .d(
-              String.format(
-                  "Report is too large to be sent via DataTransport. Maximum size is %d bytes. Report size is %d bytes. Removing report.",
-                  MAX_DATATRANSPORT_BYTES, reportSize));
-      return Tasks.forResult(reportWithSessionId);
-    }
-
     TaskCompletionSource<CrashlyticsReportWithSessionId> tcs = new TaskCompletionSource<>();
     transport.schedule(
         Event.ofUrgent(report),