Skip to content

fix broken fiam tests #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import com.google.firebase.inappmessaging.CommonTypesProto.TriggeringCondition;
import com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayCallbacks.InAppMessagingDismissType;
import com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayCallbacks.InAppMessagingErrorReason;
import com.google.firebase.inappmessaging.internal.AbtIntegrationHelper;
import com.google.firebase.inappmessaging.internal.DisplayCallbacksFactory;
import com.google.firebase.inappmessaging.internal.MetricsLoggerClient;
import com.google.firebase.inappmessaging.internal.ProgramaticContextualTriggers;
Expand Down Expand Up @@ -167,6 +168,8 @@ public class FirebaseInAppMessagingFlowableTest {
@Mock private FirebaseInstanceId instanceId;
@Mock private TestDeviceHelper testDeviceHelper;
@Mock private Subscriber firebaseEventSubscriber;
@Mock private AbtIntegrationHelper abtIntegrationHelper;

private TestSubscriber<InAppMessage> subscriber;
private FirebaseInAppMessaging instance;
private TestForegroundNotifier foregroundNotifier;
Expand Down Expand Up @@ -246,6 +249,7 @@ public void setUp() {
appComponentBuilder =
DaggerTestAppComponent.builder()
.universalComponent(universalComponent)
.testAbTestingModule(new TestAbTestingModule(abtIntegrationHelper))
.testEngagementMetricsLoggerClientModule(
new TestEngagementMetricsLoggerClientModule(app, engagementMetricsLoggerInterface))
.grpcClientModule(new GrpcClientModule(app))
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.firebase.inappmessaging;

import com.google.firebase.inappmessaging.internal.AbtIntegrationHelper;
import dagger.Module;
import dagger.Provides;

/** Test Provider for ABTesting Module */
@Module
class TestAbTestingModule {
private final AbtIntegrationHelper abtIntegrationHelper;

TestAbTestingModule(AbtIntegrationHelper abtIntegrationHelper) {
this.abtIntegrationHelper = abtIntegrationHelper;
}

@Provides
AbtIntegrationHelper providesAbtIntegrationHelper() {
return this.abtIntegrationHelper;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
// Test modules
TestApiClientModule.class,
TestEngagementMetricsLoggerClientModule.class,
TestAbTestingModule.class,

// Real modules
GrpcClientModule.class
Expand Down