Skip to content

fix broken fiam tests #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2020
Merged

fix broken fiam tests #1181

merged 2 commits into from
Jan 30, 2020

Conversation

JasonAHeron
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jan 30, 2020
@JasonAHeron JasonAHeron requested a review from vkryachko January 30, 2020 15:57
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1181 into master will decrease coverage by 3.43%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson ? ?
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective ? ?
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx ? ?
#FirebaseCrashlytics ? ?
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport ? ?
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging 51.15% <ø> (-48.85%) 520 <ø> (+520)
#FirebaseInappmessagingDisplay 34.52% <ø> (-65.48%) 129 <ø> (+129)
#FirebaseInappmessagingDisplay_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInstallations ? ?
#FirebaseSegmentation ? ?
#FirebaseStorage ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct ? ?
#Transport_TransportRuntime ? ?
Impacted Files Coverage Δ Complexity Δ
...ng/internal/injection/modules/AbTestingModule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...essaging/display/internal/layout/FiamCardView.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ebase/inappmessaging/display/internal/Logging.java 46.66% <0%> (ø) 4% <0%> (ø) ⬇️
...ernal/injection/modules/TransportClientModule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/internal/injection/modules/GrpcClientModule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...y/internal/bindingwrappers/CardBindingWrapper.java 6.06% <0%> (ø) 1% <0%> (ø) ⬇️
...pmessaging/display/internal/OnSwipeUpListener.java 87.5% <0%> (ø) 5% <0%> (ø) ⬇️
...saging/display/internal/BindingWrapperFactory.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ssaging/display/internal/PicassoErrorListener.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...al/injection/modules/ForegroundFlowableModule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 685 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08af4ed...edf4a39. Read the comment docs.

@JasonAHeron JasonAHeron merged commit 30f71bb into master Jan 30, 2020
@JasonAHeron JasonAHeron deleted the wtf_dagger branch January 30, 2020 16:18
@firebase firebase locked and limited conversation to collaborators Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants