Skip to content

Remove absolute URL condition from HMR request checker. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2019
Merged

Remove absolute URL condition from HMR request checker. #173

merged 1 commit into from
May 19, 2019

Conversation

navaru
Copy link
Contributor

@navaru navaru commented May 18, 2019

Condition not required as URLs are absolute in most cases.

<script defer async src="/0.js"></script>
// element.src -> https://domain.com/0.js

normalizeURL("domain.com/0.js")
// https://domain.com/0.js

@navaru navaru requested a review from ScriptedAlchemy as a code owner May 18, 2019 08:19
@ScriptedAlchemy
Copy link
Collaborator

Any tests that could be written for this function? I'll need to take this to webpack and having some tests as to what's going to pass/fail the regex would be helpful

@ScriptedAlchemy ScriptedAlchemy merged commit 33ccca3 into faceyspacey:master May 19, 2019
@faceyspacey
Copy link
Owner

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants