css-modules failed when using latest version.

[fwh1990]

I am using scss + css-modules, but I can't hot reload the changes of scss files since I upgrade version from 4.3.0 to 4.3.1.

I have to downgrade to 4.3.0 now.

What happened? Any idea?

[cloudychen]

me too

[ScriptedAlchemy]

Likely from this commit: 0ce2460

Send me a demo repo and ill have a look

[fwh1990]

I debug source code, and find out something may cause error:

function updateCss(el, url) {

  ...

  if (!isUrlRequest(url)) {
    return;
  }

  ...

}

The url like http://localhost:8000/main.css, so !isUrlRequest(url) return true

[fwh1990]

Would you fix this bug at your earliest convenience? I mean, don't use el.href, it will return absolute url.

[ScriptedAlchemy]

@fwh1990 open a pull request and ill review it. you know what you need better than me

[ScriptedAlchemy]

use the reloadAll command/option?

[cloudychen]

use the reloadAll command/option?

yes

[silvenon]

@fwh1990 it would be so great if you could send the PR 😁🙏

[fwh1990]

I have tested every version from 4.3.0~4.5.1, and find out that the bug was fixed by PR-173.

Everybody can upgrade to version 4.5.1, thanks.

So, I can close this issue now.