Skip to content

Prefer POSIX over GNU extensions. #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Jun 20, 2021

Also, commit espressif/esp-idf@624725d suggests that "WITH_POSIX" shall be removed from the compiler flags.
This PR aligns ESP32 to ESP8266 PR esp8266/Arduino#8150

@me-no-dev
Copy link
Member

all of the changes that you have made are to files that are auto generated by the lib builder. They will not stick. The lib builder get's the flags from IDF's compile process.

@me-no-dev me-no-dev closed this Jun 20, 2021
@dok-net
Copy link
Contributor Author

dok-net commented Jun 20, 2021

@me-no-dev OK. So you don't feel the idea itself is worth carrying forward to wherever the generation process starts? Just asking, and suggesting. Thanks for the quick response!

@dok-net dok-net deleted the xopen_source branch June 20, 2021 18:49
@me-no-dev
Copy link
Member

The proper way to do something like that is to have it configured at build time of the IDF libs in the lib-builder repo, so that when it builds IDF, it will do it with those same flags, which will then carry over to here :)

@dok-net
Copy link
Contributor Author

dok-net commented Jun 22, 2021

I am not so sure what is best anymore, anyway, now both ESP8266 and ESP32 allow the full set by defining _GNU_SOURCE . All things even, it might be more worth of consideration to migrate ESP32 to a current GCC release, than spent time pondering the "best" subset of extensions. Again, just suggesting off the top of my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants