Fix deprecation of bzero, prefer POSIX over GNU newlib extensions #8150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dok-net
force-pushed
the
xopen_source
branch
2 times, most recently
from
098ce31 to
5cdfde5
Compare
This was referenced Jun 20, 2021
|
ESP32 build settings are generated from IDF, and there _GNU_SOURCE is used, too. So the whole point is moot. Retracting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8122.
Bzero was once deprecated, apparently compiler optimizations could remove the zeroing, which for obvious reasons is a serious security issue.