Safely schedule functional ISRs: follow-up to Schedule and FunctionalInterrupt fix #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling: - VIP treatment in general attach/detach/handling looks untidy: extern symbols without matching header include but copy&paste special under-the-hood c++ delete support, where everyone else has to do their own resource tracking as usual. - FunctionalInterrupt is not used by anything inside core ESP32 Arduino for 8 months now, it can be a library, which reduces precious core size for everyone else. This reverts commit ea61563.
…th functional interrupts.
…as example code. It should be decided whether to reinstate these in the core, or make them an optional library.
…n attachInterruptArg(). This is sufficient for resource management - the function has static duration anyway.
…late the ISR in ICACHE_RAM rule (ESP8266 core catches this).
(cherry picked from commit d39be67)
… of non-IRAM ISRs via C++ std::bind, std::function, or lambdas. It is now a follow up to the introduction of Schedule.(h|cpp) into core, which supports safe scheduling of non-IRAM ISRs as they are being scheduled synchronously to loop() in the same task.
|
OMG 😮 I think all your PRs have intertwined. I would suggest you close them all and start again :) |
|
@me-no-dev Not quite so, but not a completely wrong assessment of what's going on either ;-) ;-) ;-) |
|
TBD... closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings #2734 and #2743 full-circle:
Sketch-level support of only IRAM-safe ISRs as std::bind, std::function, or lambdas, plus regular C-style support for ISRs with void* argument.