Add Schedule.(h|cpp) from ESP8266 to run off loopTask. #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d39be67)
This was referenced May 6, 2019
|
See my comments in the other PR :) |
|
I currently no longer believe that this or any existing version of Schedule is free of concurrency issues. I am revoking this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the non-intrusive part of two existing PRs by @hreintke. It provides source compatibility to ESP8266's Schedule.
An actual benefit that I would use is the ability to easily schedule (periodic) activity to the loop task, without any risk of race conditions, from interrupt service routines. I would likely use this in https://github.com/plerup/espsoftwareserial