Add MD5 hash to HTTPUpdate http request headers #2165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 5, 2018 13:59
…_rxBuffer is not initialised
|
@me-no-dev I do not know why my recent commits are included in this PR. Could you help me to get a clean master? Can you merge this, or do you need something 'cleaner'? Update: |
|
you should use branches for each PR you make. Since you are creating PRs directly from your master, all commits will show |
|
so I see them mixed. I am closing this PR and you should make a new one with just the change. BTW I advise you to get the MD5 of the sketch first and add the header only if it returned an actual string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MD5 hash to HTTPUpdate http request headers. Includes PR #2164 because it uses the function defined in that PR.