Add getSketchMD5() to ESP.h and ESP.cpp #2164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 5, 2018 13:59
…_rxBuffer is not initialised
This was referenced Dec 7, 2018
me-no-dev
reviewed
Dec 10, 2018
| uint32_t lengthLeft = getSketchSize(); | ||
|
|
||
| const esp_partition_t *running = esp_ota_get_running_partition(); | ||
| if (!running) return String(); |
There was a problem hiding this comment.
please do not use one liners like this :) also please add some log_e messages on why the call failed. It will be helpful if something goes wrong.
me-no-dev
reviewed
Dec 10, 2018
| std::unique_ptr<uint8_t[]> buf(new uint8_t[bufSize]); | ||
| uint32_t offset = 0; | ||
| if(!buf.get()) { | ||
| return String(); |
me-no-dev
reviewed
Dec 10, 2018
| while( lengthLeft > 0) { | ||
| size_t readBytes = (lengthLeft < bufSize) ? lengthLeft : bufSize; | ||
| if (!ESP.flashRead(running->address + offset, reinterpret_cast<uint32_t*>(buf.get()), (readBytes + 3) & ~3)) { | ||
| return String(); |
|
Replaced by PR #2176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it is possible to calculate the MD5 hash of the running sketch. This can be used to create a unique 'fingerprint' of the running sketch.