Skip to content

replace old Ethernet library by a submodule ref'ing the updated one #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Apr 17, 2019

@d-a-v d-a-v requested review from devyte and earlephilhower April 17, 2019 20:55
@d-a-v d-a-v added this to the 2.5.1 milestone Apr 17, 2019
@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 17, 2019

We don't need it locally because

  • we don't use it in examples
  • we can't maintain it
  • submoduling it will need regular updates following upstream (library manager is here for that)
  • we can ship it in releases like we were doing with softwareserial before it was submoduled

To be noted: softwareserial is submoduled because we use it in examples. It is an esp8266 specific library so the author is also supposed to care about this (unlike Ethernet which is more arduino generic).

edit: we can also download softwareserial in CI, remove it as a submodule, and let users handle it with the library manager.

Comments are welcome.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 19, 2019

Comments are welcome.

This library is not available from library manager (is it?)

Anyway comments came through the arduino maintainers chat board: We'd better have it locally instead of

  • letting users unsuccessfully look for where it was before
  • embed it in releases while not being available in git (like SoftwareSerial was)
  • point to a known compatible version thanks to submodule git refs

(edit: PR will fail because of arduino API compatibility and is now moved inside fixing/pending #5969)

@d-a-v d-a-v changed the title remove old Ethernet library in favour of library manager's updated one replace old Ethernet library by a submodule ref'ing the updated one Apr 19, 2019
@d-a-v d-a-v closed this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant