Skip to content

restore proper arduino Client:: & Wire:: API #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 26, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Apr 9, 2019

fixes #5749
fixes #5901
fixes #5705
includes #5997

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a specific test case, but the changes LGTM. Only possible area of concern is the

    void onReceive( void (*)(int) );    // arduino api
    void onReceive( void (*)(size_t) ); // legacy esp8266 backward compatibility

I assume you've done some testing to show this doesn't cause any of the usual type inference errors we seem to have when int-like things and ints are specified as params?

@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 11, 2019

I assume you've done some testing to show this doesn't cause any of the usual type inference errors we seem to have when int-like things and ints are specified as params?

edit
I only made a quick test with gcc -m32, assuming size_t is long unsigned int
It is a matter of signed / unsigned cast on the same integer size (verified by static_cast)
the value is a size, small and always >=0.

@earlephilhower
Copy link
Collaborator

My own testing this AM shows no problem compiling with the void cb(int) and void cb(size_t), so all good for me.

@d-a-v d-a-v changed the title restore proper arduino Client:: & Wire:: API restore proper arduino Client:: & Wire:: API, use Ethernet submodule Apr 19, 2019
@JAndrassy
Copy link
Contributor

@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 25, 2019

I don't understand the question. With this PR, Ethernet is not ours anymore.

BTW I opened a PR in ethernet repository so we can use it as a submodule arduino-libraries/Ethernet#96

@JAndrassy
Copy link
Contributor

I don't understand the question. With this PR, Ethernet is not ours anymore.

BTW I opened a PR in ethernet repository so we can use it as a submodule arduino-libraries/Ethernet#96

sorry, maybe this is not the right place. I meant to use setConnectionTimeout for WiFiClient.

@d-a-v d-a-v changed the title restore proper arduino Client:: & Wire:: API, use Ethernet submodule restore proper arduino Client:: & Wire:: API Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants