-
Notifications
You must be signed in to change notification settings - Fork 13.3k
restore proper arduino Client:: & Wire:: API #5969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have a specific test case, but the changes LGTM. Only possible area of concern is the
void onReceive( void (*)(int) ); // arduino api
void onReceive( void (*)(size_t) ); // legacy esp8266 backward compatibility
I assume you've done some testing to show this doesn't cause any of the usual type inference errors we seem to have when int-like things and ints are specified as params?
edit |
My own testing this AM shows no problem compiling with the |
sorry. why not this way https://www.arduino.cc/en/Reference/EthernetClientSetConnectionTimeout ? |
I don't understand the question. With this PR, Ethernet is not ours anymore. BTW I opened a PR in ethernet repository so we can use it as a submodule arduino-libraries/Ethernet#96 |
sorry, maybe this is not the right place. I meant to use setConnectionTimeout for WiFiClient. |
fixes #5749
fixes #5901
fixes #5705
includes #5997