-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Subtree axtls #3423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Subtree axtls #3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@82 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@84 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@88 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@89 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@90 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@91 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@92 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@93 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@94 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@95 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@96 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@97 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@98 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@99 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@100 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@101 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@102 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@103 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@105 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@106 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@107 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@108 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@109 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@110 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@111 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@112 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@114 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@116 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@117 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@118 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
…p8266#31) For HTTP public key pinning (RFC7469), the SHA-256 hash of the Subject Public Key Info (which usually only changes when the public key changes) is used rather than the SHA-1 hash of the entire certificate (which will change on each certificate renewal).
* fix memleak in rsa.c * don't alloc block from the start;check block;don't use goto * fix whitespaces
…libraries that use the sam name
* Buffer sizes tightned up. * Buffer check on client handshake due to some incompatibilities. git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@270 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
Platform- and application-specific section placement is best done in the application makefiles and linker scripts. On the other hand, compiling with split sections allows code and data usage to be reduced without tuning specific options in config file.
* Some non-C sample code updated. git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@271 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
…display. * SNI hostname memory is now managed by the calling application * X509 version number is checked before processing v3 extensions. git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@272 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@273 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
* Test harness must now be run without built-in default cert git-svn-id: svn://svn.code.sf.net/p/axtls/code/trunk@274 9a5d90b5-6617-0410-8a86-bb477d3ed2e3
Constant text strings actually take up SRAM space on the ESP8266 because the .RODATA segment must be copied to RAM at startup since FLASH isn't byte-accessible. Move the constant format strings in a printf completely into FLASH and add a wrapper to copy it into a local stack-allocated space when needed, freeing up about 3100 bytes of RAM for use. This doesn't make FLASH usage any higher, either, since those strings were already being stored there (but never used after the power-on startup code). Minor edits required in some of the output/debug/tracing functions, but no logic changed.
git-subtree-dir: tools/sdk/axtls git-subtree-split: 27f4a6c
….cpp to use the axtls version of the sha1 algorithm, removed the custom sha 1 implementation
git-subtree-dir: tools/sdk/axtls git-subtree-split: 27f4a6c
Whoops. Wrong branch. Disregard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to get cracking again on #3105 but based on the feedback from @igrr and the comments on #3223 I thought it worth tackling bringing AxTLS in to the build tree.
Using a submodule would work, but they are error prone (forgetting to sync up the submodules is a pain), so I thought about using a subtree, but as I was refreshing my memory on how to set them up, I came across this subrepo project: https://github.com/ingydotnet/git-subrepo#readme. Have a read through, though the TL;DR is there is no extra software or things to worry about for developer just working on the top level repo (ie almost everbody), and there is just an additional script forr those working with the axtls repo.
I've added in https://github.com/igrr/axtls-8266 (in the tools/sdk/axtls directory) and replaced the sha1 implementation in Hash.cpp to use the one from the library instead of the standalone implementation that is currently used.
I've also hacked the library so it would compile when using WifiClientSecure, however it's become clear that some code from the axtls has already been manually copied over, and there has been a few other modifications to the library that may be better located in the core tree.
IMO it would makes sense to have the axtls library as close to the sourceforce version, to make updating easier, so any ESP8266 specific stuff should be in core (where possible).
So my questions:
I wouldn't mind having a bit of a discussion before committing time to cleaning this all up.