Skip to content

Some Naming and Cosmetic Change Offers #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozayturay opened this issue Apr 1, 2015 · 2 comments
Closed

Some Naming and Cosmetic Change Offers #30

ozayturay opened this issue Apr 1, 2015 · 2 comments

Comments

@ozayturay
Copy link

To visually match the Arduino IDE naming conventions and general ESP8266 naming here are my suggestions:

platform.txt:

As in ESP8266 world boards are called as modules, so name should include the word "Modules"

name=Arduino ESP8266 Modules

programmers.txt:

In Arduino IDE all programmer names start with capital letter so captalizing ESPTool should look good
esptool.name=ESPTool

boards.txt

As there are several modules esp01.xxx definitions should be converted to generic.xxx and esp01 in variants directory should be renamed accordingly.

Variant names should include Module as above and esp01's replaced by generic elsewhere

generic.name=Generic ESP8266 Module
generic.build.board=ESP8266_GENERIC
generic.build.variant=generic

wifio.name=WIFIO Module

@igrr igrr closed this as completed in e9a0b13 Apr 3, 2015
igrr added a commit that referenced this issue Apr 3, 2015
* origin/esp8266:
  Naming changes as suggested in #30
@ozayturay
Copy link
Author

There is still an ESP01 word left in boards.txt

generic.build.board=ESP8266_ESP01

İt sould better be

generic.build.board=ESP8266_GENERIC

@ozayturay
Copy link
Author

And the line

wifio.upload.tool=esptool

is duplicated.

igrr added a commit that referenced this issue Oct 29, 2015
igrr added a commit that referenced this issue Oct 29, 2015
* origin/esp8266:
  Naming changes as suggested in #30
igrr pushed a commit that referenced this issue Oct 29, 2015
madpilot pushed a commit to madpilot/Arduino that referenced this issue Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants