-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update SDK to 2.0.0 #2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to 2.0.0 #2440
Conversation
Codecov Report@@ Coverage Diff @@
## master #2440 +/- ##
=======================================
Coverage 27.82% 27.82%
=======================================
Files 20 20
Lines 3626 3626
Branches 656 656
=======================================
Hits 1009 1009
Misses 2441 2441
Partials 176 176 Continue to review full report at Codecov.
|
Size difference report:
|
Size difference looks good 👍 |
@igrr - this PR looks very promising with memory consumption. compare memory usage (my project ino with built-in wire implemetation): |
Thanks for testing. |
https://www.google.com.au/search?q=espconn.h+filetype:ino Only 3 hits by the looks of it... |
It seems that there is one notable library which uses espconn: https://github.com/i-n-g-o/esp-mqtt-arduino. |
I have updated this PR in such a way that |
What is left to figure out is what to do with |
This is interesting https://github.com/pvvx/esp8266web/blob/2e25559bc489487747205db2ef171d48326b32d4/info/libs/main/startup.c#L205-L217 Is it related to your question? Would love to see this merged so I can take advantage of some of the new 2.x features! Cheers. |
Yes, that's the part of startup code where these two functions are called depending on chip ID. The problem is that a choice has to be made: either keep these functions, but add a lot of code into IRAM, or we remove them, but then these flash chips will be unsupported. As stated above, I don't have usage data for these two flash chips, so I don't know whether removing these functions will have an impact on users. |
@igrr does SDK 2.0 include a more recent LWIP version now as discussed some time ago? Would love to retest if the high latency connection crashes are resolved? |
I wonder why this branch didn't pass at the time. I also would like to help but I don't know how you guys do. I mean if I were to merge the current base branch with esp nonOs SDK 2 wouldn't know how to get started. |
36c419b
to
6b15ce3
Compare
- Update SDK header files and libraries to SDK 2.0.0 plus 2.0.0_16_08_09 patch - Remove mem_manager.o from libmain.a (replaced with umm_malloc) - Disable switch from DIO to QIO mode for certain flash chips (saves IRAM space) - Add user_rf_cal_sector_set; it points to rf_init_data sector. - Change the way rf_init_data is spoofed. This is now done by wrapping spi_flash_read and returning the data we need during startup sequence. - Place lwip library into flash using linker script instead of section attributes (saves IRAM space)
6b15ce3
to
7f6daa2
Compare
|
This is now done by wrapping spi_flash_read and returning the data we need during startup sequence.
from startup code (using objcopy --rename-symbol, for example)