-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[WIP] Update SDK to 2.0.0 (#2304) #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76ba772
to
a8259fe
Compare
Current coverage is 27.62% (diff: 100%)@@ master #2317 diff @@
==========================================
Files 20 20
Lines 3656 3656
Methods 335 335
Messages 0 0
Branches 678 678
==========================================
Hits 1010 1010
Misses 2468 2468
Partials 178 178
|
d46b19b
to
d4dbbc7
Compare
d4dbbc7
to
ec59372
Compare
@igrr, what are the next steps? Here's something from the top of my head:
|
Flash layout needs to be fixed:
Other things to do:
|
Opened #2440 which addresses points outlined above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those who will struggle to run this with PlatformIO (I have version 2.11.1), here is a guide:
~/.platformio/packages/framework-arduinoespressif/
.platformio.ini
(bluntly stolen from Compilation error with Ardino/master, lack of newlibc maybe? #2263):~/.platformio/.platformio/packages/ldscripts/esp8266.flash.common.ld
.It should comply with changes from files in this repo:
Arduino/tools/sdk/ld/eagle.app.v6.common.ld
Arduino/tools/sdk/ld/eagle.rom.addr.v6.ld
In my case, I had to apply the following changes: