Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Build: Add Node 6.x to Travis #98

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Conversation

dannyfritz
Copy link
Contributor

Finishing what #57 started.

@eslintbot
Copy link

Thanks for the pull request, @dannyfritz! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

@@ -3,5 +3,8 @@ sudo: false
node_js:
- "0.12"
- 4
- 6
before_script:
- npm install typescript@^1.7.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can pull the version from package.json so we don't have to worry about keeping the versions in sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this as a devDependency and run it instead. https://www.npmjs.com/package/npm-install-peers

@nzakas
Copy link
Member

nzakas commented Sep 21, 2016

Also, this should be "Build:"

@eslintbot
Copy link

LGTM

@dannyfritz dannyfritz changed the title Chore: Add Node 6.x to Travis Build: Add Node 6.x to Travis Sep 21, 2016
@dannyfritz
Copy link
Contributor Author

dannyfritz commented Sep 21, 2016

Oh geez, 0.12 can't run npm-install-peers:

const chalk = require('chalk')
^^^^^
SyntaxError: Use of const in strict mode.

I found an answer that uses sed to do it, but don't want to commit it because I don't understand it. npm/npm#11213 (comment)

@eslintbot
Copy link

LGTM

@dannyfritz
Copy link
Contributor Author

Working with npm-install-peers to resolve this: spatie/npm-install-peers#2

@eslintbot
Copy link

LGTM

@dannyfritz dannyfritz changed the title Build: Add Node 6.x to Travis 🚧WIP: Build: Add Node 6.x to Travis Sep 25, 2016
@JamesHenry
Copy link
Member

@nzakas I am wondering if node 0.12 should even be a consideration at this point... It's maintenance support will be discontinued at the end of the year, and node 4.x has long since been the LTS.

It would really surprise me if there are many users of TypeScript and node 0.12 as a combination out there.

What do you think?

@eslintbot
Copy link

LGTM

@dannyfritz dannyfritz changed the title 🚧WIP: Build: Add Node 6.x to Travis Build: Add Node 6.x to Travis Sep 26, 2016
@dannyfritz
Copy link
Contributor Author

Got a PR in for npm-install-peers and this should be good to go now.

spatie/npm-install-peers#3

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 4dd3439 into eslint:master Sep 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants