-
-
Notifications
You must be signed in to change notification settings - Fork 75
Update: Added travis ci support for modern node versions #57
Conversation
Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
node_js: | ||
- "0.12" | ||
- 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put in increasing version number order
Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Fixed |
Can you sign the CLA? Also, it looks like the Node 6 environment is failing, so this can't be merged into that is addressed. Can you investigate? |
@amilajack I took a brief look and my guess is that TypeScript is not installed automatically in 6.x because it is a peer dependency. Also you need to squash your commits and follow the ESLint contributors guide. http://eslint.org/docs/developer-guide/contributing/pull-requests |
This PR should be closed and not merged. #98 solved this. |
Thanks @dannyfritz, closing per your comment. |
No description provided.