Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Update: Added travis ci support for modern node versions #57

Closed
wants to merge 3 commits into from

Conversation

amilajack
Copy link
Contributor

No description provided.

@eslintbot
Copy link

Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@amilajack amilajack changed the title Added travis ci support for modern node versions Update: Added travis ci support for modern node versions Aug 18, 2016
node_js:
- "0.12"
- 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put in increasing version number order

@eslintbot
Copy link

Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslintbot
Copy link

Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@amilajack
Copy link
Contributor Author

Fixed

@nzakas
Copy link
Member

nzakas commented Aug 19, 2016

Can you sign the CLA? Also, it looks like the Node 6 environment is failing, so this can't be merged into that is addressed. Can you investigate?

@dannyfritz
Copy link
Contributor

dannyfritz commented Sep 17, 2016

@amilajack I took a brief look and my guess is that TypeScript is not installed automatically in 6.x because it is a peer dependency.

http://stackoverflow.com/questions/33618987/node-js-and-npm-v3-how-to-add-travis-tests-compatible-peerdependencies-in-packa


Also you need to squash your commits and follow the ESLint contributors guide. http://eslint.org/docs/developer-guide/contributing/pull-requests

@dannyfritz
Copy link
Contributor

This PR should be closed and not merged. #98 solved this.

@platinumazure
Copy link
Member

Thanks @dannyfritz, closing per your comment.

@amilajack amilajack deleted the patch-1 branch October 3, 2016 01:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants