Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix type parameter start location calculation #259

Merged
merged 2 commits into from
May 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ast-converter.js
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,8 @@ module.exports = function(ast, extra) {
* Have to manually calculate the start of the range,
* because TypeScript includes leading whitespace but Flow does not
*/
var typeParameterStart = (typeParameter.typeName && typeParameter.typeName.text)
? typeParameter.end - typeParameter.typeName.text.length
var typeParameterStart = (typeParameter.name && typeParameter.name.text)
? typeParameter.name.end - typeParameter.name.text.length
: typeParameter.pos;

var defaultParameter = typeParameter.default
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ module.exports = {
"line": 1
},
"start": {
"column": 23,
"column": 24,
"line": 1
}
},
"name": "U",
"range": [
23,
24,
25
],
"type": "TypeParameter",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,13 @@ module.exports = {
"line": 1
},
"start": {
"column": 19,
"column": 20,
"line": 1
}
},
"name": "U",
"range": [
19,
20,
21
],
"type": "TypeParameter",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,229 @@
module.exports = {
body: [{
async: false,
body: {
body: [],
loc: {
end: {
column: 35,
line: 1
},
start: {
column: 33,
line: 1
}
},
range: [33, 35],
type: "BlockStatement"
},
expression: false,
generator: false,
id: {
loc: {
end: {
column: 16,
line: 1
},
start: {
column: 9,
line: 1
}
},
name: "compare",
range: [9, 16],
type: "Identifier"
},
loc: {
end: {
column: 35,
line: 1
},
start: {
column: 0,
line: 1
}
},
params: [],
range: [0, 35],
type: "FunctionDeclaration",
typeParameters: {
loc: {
end: {
column: 30,
line: 1
},
start: {
column: 16,
line: 1
}
},
params: [{
constraint: null,
loc: {
end: {
column: 29,
line: 1
},
start: {
column: 28,
line: 1
}
},
name: "T",
range: [28, 29],
type: "TypeParameter"
}],
range: [16, 30],
type: "TypeParameterDeclaration"
}
}],
loc: {
end: {
column: 35,
line: 1
},
start: {
column: 0,
line: 1
}
},
range: [0, 35],
sourceType: "script",
tokens: [{
loc: {
end: {
column: 8,
line: 1
},
start: {
column: 0,
line: 1
}
},
range: [0, 8],
type: "Keyword",
value: "function"
},
{
loc: {
end: {
column: 16,
line: 1
},
start: {
column: 9,
line: 1
}
},
range: [9, 16],
type: "Identifier",
value: "compare"
},
{
loc: {
end: {
column: 17,
line: 1
},
start: {
column: 16,
line: 1
}
},
range: [16, 17],
type: "Punctuator",
value: "<"
},
{
loc: {
end: {
column: 29,
line: 1
},
start: {
column: 28,
line: 1
}
},
range: [28, 29],
type: "Identifier",
value: "T"
},
{
loc: {
end: {
column: 30,
line: 1
},
start: {
column: 29,
line: 1
}
},
range: [29, 30],
type: "Punctuator",
value: ">"
},
{
loc: {
end: {
column: 31,
line: 1
},
start: {
column: 30,
line: 1
}
},
range: [30, 31],
type: "Punctuator",
value: "("
},
{
loc: {
end: {
column: 32,
line: 1
},
start: {
column: 31,
line: 1
}
},
range: [31, 32],
type: "Punctuator",
value: ")"
},
{
loc: {
end: {
column: 34,
line: 1
},
start: {
column: 33,
line: 1
}
},
range: [33, 34],
type: "Punctuator",
value: "{"
},
{
loc: {
end: {
column: 35,
line: 1
},
start: {
column: 34,
line: 1
}
},
range: [34, 35],
type: "Punctuator",
value: "}"
}
],
type: "Program"
};
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
function compare</*comment*/T>() {}