Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix type parameter start location calculation #259

Merged
merged 2 commits into from
May 6, 2017

Conversation

Igorbek
Copy link
Contributor

@Igorbek Igorbek commented May 6, 2017

Before:

function compare</*comment*/T,    U>() {}
//               ~~~~~~~~~~~~ TypeParameter T
//                            ~~~~~ TypeParameter U

After:

function compare</*comment*/T,    U>() {}
//                          ~ TypeParameter T
//                                ~ TypeParameter U

@jsf-clabot
Copy link

jsf-clabot commented May 6, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @Igorbek! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@Igorbek Igorbek force-pushed the fix/type-parameter-start branch from 818864b to 31023b0 Compare May 6, 2017 16:16
@eslintbot
Copy link

Thanks for the pull request, @Igorbek! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

- use `name` field instead of `typeName` (fixes eslint#260)
@Igorbek Igorbek force-pushed the fix/type-parameter-start branch from 31023b0 to ecb0366 Compare May 6, 2017 16:17
@eslintbot
Copy link

Thanks for the pull request, @Igorbek! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JamesHenry JamesHenry merged commit d37bf04 into eslint:master May 6, 2017
@Igorbek Igorbek deleted the fix/type-parameter-start branch May 6, 2017 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants