This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Calculate range correctly when generic class is exported (fixes #152) #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
…nt#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.
soda0289
force-pushed
the
fix-class-body-range-generics
branch
from
8789bb9 to
28d1344
Compare
|
LGTM |
|
I missed a case earlier. I have tested this with extends and implements clauses as well. Let me know if I should add tests for theses cases. We already have tests for implements and extends but not with export. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class with a generic definition is exported we must take the
type parameters into account when finding the opening brace. This
continues the fix of pull request #153 and handles the case of exporting
a class with generics. We now find the last type parameter and use the
succeeding token as the opening brace.