Class body has invalid range that breaks brace-style rule #152

soda0289 · 2017-01-31T21:45:08Z

I noticed on the newer version of eslint (3.14) that the brace style rule fails on exported classes. The opening brace variable used in the rule is incorrect since it is pointing to the identifier 'hello'. I believe the class body node's range is wrong and is still including the identifier. Have not tested on typescript 2.0.3. Will try and submit pr with fix.

What version of TypeScript are you using?
2.1.3

What version of typescript-eslint-parser are you using?
ts-2.1

What code were you trying to parse?

export class hello {

    hello () {

    }
}

What did you expect to happen?
Should parse correctly with brace-style 1tbs

What happened?
Failed with error:
2:14 error Statement inside of curly braces should be on next line brace-style

The text was updated successfully, but these errors were encountered:

soda0289 · 2017-02-01T20:48:48Z

This also effects typescript 2.0.3 with master. Will submit pull request with fix.

JamesHenry · 2017-02-01T22:11:28Z

Thanks so much for your efforts, @soda0289! I've been so swamped in January but things are set to improve from next week.

The range of a class body should be from the opening brace to the closing brace. To find the opening brace the ast converter parses over modifiers of the class declaration and assumes it is the last token after the last node modifier. This assumption is not always true when the class is exported. This commit ensures we only skip over modifiers which are after the class name or heritage clause.

…) (eslint#153) The range of a class body should be from the opening brace to the closing brace. To find the opening brace the ast converter parses over modifiers of the class declaration and assumes it is the last token after the last node modifier. This assumption is not always true when the class is exported. This commit ensures we only skip over modifiers which are after the class name or heritage clause.

…slint#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.

…nt#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.

#155)

eslintbot added the triage label Jan 31, 2017

soda0289 changed the title ~~Class body has invalid range that brakes brace-style rule~~ Class body has invalid range that breaks brace-style rule Feb 1, 2017

nzakas closed this as completed in e5f378f Feb 5, 2017

JamesHenry pushed a commit that referenced this issue Feb 10, 2017

Fix: Calculate range correctly for exported generic class (fixes #152) (

e96ba1f

#155)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class body has invalid range that breaks brace-style rule #152

Class body has invalid range that breaks brace-style rule #152

soda0289 commented Jan 31, 2017

soda0289 commented Feb 1, 2017

JamesHenry commented Feb 1, 2017

Class body has invalid range that breaks brace-style rule #152

Class body has invalid range that breaks brace-style rule #152

Comments

soda0289 commented Jan 31, 2017

soda0289 commented Feb 1, 2017

JamesHenry commented Feb 1, 2017