Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

WIP Fix tests for Typescript 2.1 #130

Closed
wants to merge 2 commits into from

Conversation

soda0289
Copy link
Member

Fixes tests for issue #128

I'm still looking into this. Thought I would post some initial progress. Any feedback is appreciated.

In typescript 2.1 the ModifierFlag is used, instead of NodeFlags,
to mark static methods in the AST.
@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

In Typescript 2.1 the SyntaxKind enum uses SpreadElement instead
of SpreadElementExpression
@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@JamesHenry
Copy link
Member

Thanks a lot for starting work on this, @soda0289!

I found it very useful when adding TS 2 support, to first research and map out all the relevant changes on the issue, before submitting any PRs (#105).

Let's work together on that for this TS 2.1 work by using the existing issue here #128 and we can get a PR with the updates merged ASAP.

@JamesHenry JamesHenry closed this Jan 1, 2017
@soda0289 soda0289 deleted the fix-tests-typescript-2.1 branch May 23, 2017 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants