Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

TypeScript 2.x Support #105

Closed
10 tasks done
JamesHenry opened this issue Oct 13, 2016 · 7 comments
Closed
10 tasks done

TypeScript 2.x Support #105

JamesHenry opened this issue Oct 13, 2016 · 7 comments
Assignees

Comments

@JamesHenry
Copy link
Member

JamesHenry commented Oct 13, 2016



@JamesHenry JamesHenry self-assigned this Oct 13, 2016
This was referenced Oct 13, 2016
@JamesHenry
Copy link
Member Author

JamesHenry commented Oct 22, 2016

Update:

The decorators/method-decorators/method-decorator-factory-instance-member and decorators/method-decorators/method-decorator-instance-member tests fail because I just so happen to have called my made up decorator readonly, which became a keyword in TypeScript 2.

@JamesHenry
Copy link
Member Author

JamesHenry commented Oct 22, 2016

The basics/declare-namespace-with-exported-function test fails because a particular flags value on the deeplyCopy()ed TSNode has changed between TS 1.x and TS 2.x

Whilst we do use TSNode.flags for some node checks, there is not actually any reason to pass them through to the converted AST when using the deeplyCopy() fallback. It does not currently provide any benefit, and we will always be exposed to these kinds of changes.

Therefore the change I will make is to exclude flags from the copy process, rather than changing the value in the final AST.

@JamesHenry
Copy link
Member Author

jsx/tag-names-with-dots and jsx/tag-names-with-multi-dots were pretty tricky to track down and fix.

The change is AST between TS 1.8.10 and TS 2.0.3 can be attributed to this PR microsoft/TypeScript#7645

@dannyfritz
Copy link
Contributor

Dang that was quick. ✨

@corbinu
Copy link

corbinu commented Nov 5, 2016

Nice work! as soon is up will run it through my Smoke Testing (obviously most will fail still) but hopefully when Eslint 4 drops we will be 100%!

@nzakas nzakas closed this as completed in 9521396 Nov 8, 2016
@corbinu
Copy link

corbinu commented Nov 9, 2016

@JamesHenry Ran the smoke tests. No new failures.

https://gitlab.com/corbinu/eslint-typescript-smoketest/pipelines/4930979

All the failures are still in escope (as expected) except for the nativescript groceries sample which is failing on no-unused-vars and no-undef which is not unexpected either.

https://gitlab.com/corbinu/eslint-typescript-smoketest/builds/6041509

@JamesHenry
Copy link
Member Author

Cool, thanks @corbinu! Now that TS 2 support is in, I'll be looking at the escope stuff

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants