Fix: Ensure require-meta-* rules test null / undefined property values
#164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
meta-property-undefined-null
branch
from
9f296c2 to
421b2a7
Compare
bmish
changed the title
require-meta-* rules test null / undefined property valuesrequire-meta-* rules test null / undefined property values
|
a conflict needs to be resolved. |
We need to ensure that the rules correctly handle `null` / `undefined` as the value of the meta properties since these values are commonly used as placeholder values.
bmish
force-pushed
the
meta-property-undefined-null
branch
from
421b2a7 to
387e0b6
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure that the rules correctly handle
null/undefinedas the value of the meta properties since these values are commonly used as placeholder values.Fixes one bug and adds test coverage.