Fix: Ensure require-meta-* rules test null/undefined property values

We need to ensure that the rules correctly handle `null` / `undefined` as the value of the meta properties since these values are commonly used as placeholder values.

Author: bmish

lib/rules/require-meta-schema.js

@@ -68,7 +68,7 @@ module.exports = {
         }
 
         let { value } = schemaNode;
-        if (value.type === 'Identifier') {
+        if (value.type === 'Identifier' && value.name !== 'undefined') {
           const variable = findVariable(
             scopeManager.acquire(value) || scopeManager.globalScope,
             value

tests/lib/rules/require-meta-docs-description.js

@@ -133,6 +133,26 @@ ruleTester.run('require-meta-docs-description', rule, {
       output: null,
       errors: [{ messageId: 'wrongType', type: 'Literal' }],
     },
+    {
+      code: `
+        module.exports = {
+          meta: { docs: { description: null } },
+          create(context) {}
+        };
+      `,
+      output: null,
+      errors: [{ messageId: 'wrongType', type: 'Literal' }],
+    },
+    {
+      code: `
+        module.exports = {
+          meta: { docs: { description: undefined } },
+          create(context) {}
+        };
+      `,
+      output: null,
+      errors: [{ messageId: 'wrongType', type: 'Identifier' }],
+    },
     {
       code: `
         const DESCRIPTION = true;

tests/lib/rules/require-meta-has-suggestions.js

@@ -74,6 +74,24 @@ ruleTester.run('require-meta-has-suggestions', rule, {
       }
     };
     `,
+    // No suggestions reported, hasSuggestions property set to `null`.
+    `
+    module.exports = {
+      meta: { hasSuggestions: null },
+      create(context) {
+        context.report({node, message});
+      }
+    };
+    `,
+    // No suggestions reported, hasSuggestions property set to `undefined`.
+    `
+    module.exports = {
+      meta: { hasSuggestions: undefined },
+      create(context) {
+        context.report({node, message});
+      }
+    };
+    `,
     // No suggestions reported, hasSuggestions property set to false (as variable).
     `
     const hasSuggestions = false;
@@ -197,6 +215,26 @@ ruleTester.run('require-meta-has-suggestions', rule, {
       `,
       errors: [{ messageId: 'shouldBeSuggestable', type: 'Literal', line: 3, column: 35, endLine: 3, endColumn: 40 }],
     },
+    {
+      // Reports suggestions, hasSuggestions property set to `null`, violation should be on `null`
+      code: `
+        module.exports = {
+          meta: { hasSuggestions: null },
+          create(context) { context.report({node, message, suggest: [{}]}); }
+        };
+      `,
+      errors: [{ messageId: 'shouldBeSuggestable', type: 'Literal', line: 3, column: 35, endLine: 3, endColumn: 39 }],
+    },
+    {
+      // Reports suggestions, hasSuggestions property set to `undefined`, violation should be on `undefined`
+      code: `
+        module.exports = {
+          meta: { hasSuggestions: undefined },
+          create(context) { context.report({node, message, suggest: [{}]}); }
+        };
+      `,
+      errors: [{ messageId: 'shouldBeSuggestable', type: 'Identifier', line: 3, column: 35, endLine: 3, endColumn: 44 }],
+    },
     {
       // Reports suggestions, hasSuggestions property set to false (as variable), violation should be on variable
       code: `

tests/lib/rules/require-meta-schema.js

@@ -129,6 +129,16 @@ schema: [] },
       output: null,
       errors: [{ messageId: 'wrongType', type: 'Literal' }],
     },
+    {
+      code: `
+        module.exports = {
+          meta: { schema: undefined },
+          create(context) {}
+        };
+      `,
+      output: null,
+      errors: [{ messageId: 'wrongType', type: 'Identifier' }],
+    },
     {
       code: `
         const schema = null;