Skip to content

Error: Use messageId instead of message is incorrect for field desc #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nopeless opened this issue Jun 13, 2023 · 3 comments · Fixed by #355
Closed

Error: Use messageId instead of message is incorrect for field desc #354

nopeless opened this issue Jun 13, 2023 · 3 comments · Fixed by #355
Labels
bug

Comments

@nopeless
Copy link
Contributor

This error will show if the suggestion has desc instead of messageId

The error message is misleading

I am willing to submit a PR
@bmish bmish added the bug label Jun 13, 2023
@bmish
Copy link
Member

bmish commented Jun 13, 2023

I assume you're talking about the prefer-message-ids rule. Yes, it would make sense to update the violation message to mention desc when reporting on a suggestion.

@nopeless
Copy link
Contributor Author

so should I fix it

@bmish
Copy link
Member

bmish commented Jun 13, 2023

PR welcome!

nopeless added a commit to nopeless/eslint-plugin-eslint-plugin that referenced this issue Jun 13, 2023
@nopeless
fix: misleading foundMessage (eslint-community#354)
1773e57
@nopeless nopeless mentioned this issue Jun 13, 2023
Merged
nopeless added a commit to nopeless/eslint-plugin-eslint-plugin that referenced this issue Jun 13, 2023
@nopeless
fix: misleading foundMessage (eslint-community#354)
8ae277e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak violation message in prefer-message-ids rule nopeless/eslint-plugin-eslint-plugin
2 participants
@bmish @nopeless