Skip to content

Commit 1773e57

Browse files
committed
fix: misleading foundMessage (eslint-community#354)
1 parent f2ed62d commit 1773e57

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/rules/prefer-message-ids.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module.exports = {
1313
type: 'problem',
1414
docs: {
1515
description:
16-
'require using `messageId` instead of `message` to report rule violations',
16+
'require using `messageId` instead of `message` or `desc` to report rule violations',
1717
category: 'Rules',
1818
recommended: true,
1919
url: 'https://github.com/eslint-community/eslint-plugin-eslint-plugin/tree/HEAD/docs/rules/prefer-message-ids.md',
@@ -23,7 +23,10 @@ module.exports = {
2323
messages: {
2424
messagesMissing:
2525
'`meta.messages` must contain at least one violation message.',
26-
foundMessage: 'Use `messageId` instead of `message`.',
26+
// Currently the codebase does not distinguish between `message` and `desc`.
27+
// `utils.collectReportViolationAndSuggestionData` returns `message` for both.
28+
foundMessage:
29+
'Use `messageId` instead of `message` (for reports) or `desc` (for suggestions).',
2730
},
2831
},
2932

0 commit comments

Comments
 (0)