Skip to content

Refactored pre-requisites of build_man #13853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

Refactored pre-requisites of build_man #13853

merged 1 commit into from
Sep 26, 2024

Conversation

ariel-anieli
Copy link
Contributor

  • man/iex.1 & man/elixir.1 are evaluated from BUILD_MANPAGES
  • no diff in output of build_man.
# git log -n1 --oneline --pretty=short
commit 458a00b2a (HEAD -> makefile)
Author: Ariel Otilibili <[email protected]>

    Refactored pre-requisites of `build_man`

# make build_man -n > /tmp/makefile; echo $?
0

# git switch main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

# git log -n1 --oneline --pretty=short
commit b5282802a (HEAD -> main, origin/main, origin/HEAD)
Author: Jean Klingler <[email protected]>

    Disable migrate_unless within defmacro and remove dbg for unless (#13850)

# make build_man -n > /tmp/main; echo $?
0

# diff /tmp/makefile /tmp/main; echo $?
0

@ariel-anieli
Refactored pre-requisites of build_man
d1a647a 
* `man/iex.1` & `man/elixir.1` are evaluated from `BUILD_MANPAGES`
* no diff in output of `build_man`.

```
$ git log -n1 --oneline --pretty=short
commit 458a00b2a (HEAD -> makefile)
Author: Ariel Otilibili <[email protected]>

    Refactored pre-requisites of `build_man`

$ make build_man -n > /tmp/makefile; echo $?
0

$ git switch main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

$ git log -n1 --oneline --pretty=short
commit b528280 (HEAD -> main, origin/main, origin/HEAD)
Author: Jean Klingler <[email protected]>

    Disable migrate_unless within defmacro and remove dbg for unless (elixir-lang#13850)

$ make build_man -n > /tmp/main; echo $?
0

$ diff /tmp/makefile /tmp/main; echo $?
0
```

Signed-off-by: Ariel Otilibili <[email protected]>
@ariel-anieli
Copy link
Contributor Author

Hello; is there any news on the PR?

@josevalim josevalim merged commit ae49e4e into elixir-lang:main Sep 26, 2024
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@ariel-anieli
Copy link
Contributor Author

🙂 Awesome!

@ariel-anieli ariel-anieli deleted the makefile branch September 26, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ariel-anieli @josevalim