Disable migrate_unless within defmacro #13850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 22, 2024
| @@ -652,36 +652,6 @@ defmodule MacroTest do | |||
| """ | |||
| end | |||
|
|
|||
| test "unless expression" do | |||
There was a problem hiding this comment.
I'd go ahead and remove the dbg feature altogether.
josevalim
approved these changes
Sep 22, 2024
ariel-anieli
added a commit
to ariel-anieli/elixir
that referenced
this pull request
Sep 22, 2024
* `man/iex.1` & `man/elixir.1` are evaluated from `BUILD_MANPAGES` * no diff in output of `build_man`. ``` $ git log -n1 --oneline --pretty=short commit 458a00b2a (HEAD -> makefile) Author: Ariel Otilibili <[email protected]> Refactored pre-requisites of `build_man` $ make build_man -n > /tmp/makefile; echo $? 0 $ git switch main Switched to branch 'main' Your branch is up to date with 'origin/main'. $ git log -n1 --oneline --pretty=short commit b528280 (HEAD -> main, origin/main, origin/HEAD) Author: Jean Klingler <[email protected]> Disable migrate_unless within defmacro and remove dbg for unless (elixir-lang#13850) $ make build_man -n > /tmp/main; echo $? 0 $ diff /tmp/makefile /tmp/main; echo $? 0 ``` Signed-off-by: Ariel Otilibili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
format --migratewould break the Elixir codebase as of now, this PR fixes it:defmacro- we can resue this approach for the pipe operator for thisdbgsince we plan to deprecate - or is that too early? I can perhaps try to find a workaround usingCode.eval_stringin this case