Use System.cmd rather than System.shell for Rebar3 to avoid escaping #13751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
| @@ -207,8 +207,15 @@ defmodule Mix.Tasks.Deps.Compile do | |||
| {"TERM", "dumb"} | |||
| ] | |||
|
|
|||
| cmd = "#{rebar_cmd(dep)} bare compile --paths #{escape_path(lib_path)}" | |||
| do_command(dep, config, cmd, false, env) | |||
| rebar = Mix.Rebar.local_rebar_path(:rebar3) || handle_rebar_not_found(dep) | |||
There was a problem hiding this comment.
Dialyzer points out that Mix.Rebar.local_rebar_path(:rebar3) always returns a binary so it's truthy, so || handle_rebar_not_found(dep) and the whole def handle_rebar_not_found function are unreachable
There was a problem hiding this comment.
Thank you, I will push a fix soon. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13750.