Path escaping for rebar shell command in deps.compile.ex

[gdyr]

elixir/lib/mix/lib/mix/tasks/deps.compile.ex

Line 210 in 99be673

cmd = "#{rebar_cmd(dep)} bare compile --paths #{escape_path(lib_path)}"

Compilation of Phoenix dependency "telemetry" using Rebar fails when parentheses (or presumably other shell-significant characters) appear in the project path.

This is due to inadequate escaping in escape_path()...

elixir/lib/mix/lib/mix/tasks/deps.compile.ex

Line 225 in 99be673

String.replace(path, " ", escape)

... but could be avoided by using System.cmd()/3 instead of Mix.shell().cmd(), to pass arguments without needing to escape them.

I've attempted a fix in 806a889, but this breaks the case where there is a space in the path to rebar - if I get more time, I'll continue investigating, but perhaps someone else may want to pick this up in the meantime?

[josevalim]

@gdyr can you please send a PR with your changes so far? I don't see why a space on the path to rebar would be a problem.

[josevalim]

Actually, the root problem is here: https://github.com/elixir-lang/elixir/blob/main/lib/mix/lib/mix/rebar.ex#L218

[josevalim]

Closing in favor of the PR: #13751 Thanks!