Change required_native_memory_bytes type to ByteSize #2740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svalbuena
changed the title
svalbuena
changed the title
maxhniebergall
merged commit 6f1b9b9
into
elastic:svalbuena-issue-2739
8 of 9 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Change required_native_memory_bytes to ByteSize * run make --------- Co-authored-by: Max Hniebergall <[email protected]> (cherry picked from commit 6f1b9b9)
|
Hi @svalbuena, thanks for reporting and fixing this issue! Due to an issue with our CI, we need to have a PR from a branch in this repo to main. I've merged your PR into a local branch, and I will open a new PR to merge this new branch into main. Another PR has also been opened to backport this bugfix to the latest release. |
maxhniebergall
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Change required_native_memory_bytes to ByteSize * run make --------- Co-authored-by: Max Hniebergall <[email protected]> (cherry picked from commit 6f1b9b9) Co-authored-by: Sergi Valbuena Garrido <[email protected]>
maxhniebergall
added a commit
that referenced
this pull request
Jul 26, 2024
* Change required_native_memory_bytes to ByteSize * run make --------- Co-authored-by: Sergi Valbuena Garrido <[email protected]>
|
Your changes have been merged. Thanks for this contribution, and congrats on merging your first elastic PR! |
|
Thank you! Whats the process of updating the .net client repo with the new autogenerated code? @maxhniebergall |
|
@svalbuena, because we backported the code to v8.15.0, the new generated client code will be available with the v8.15.0 release which is happening very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2739. The required_native_memory_bytes represents a value in bytes, an integer is too small to fit the range, and other bytes parameters in the spec are already using the ByteSyze type.