Skip to content

Wrong type for required_native_memory_bytes (TrainedModelSizeStats class) #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svalbuena opened this issue Jul 26, 2024 · 0 comments · Fixed by #2740
Closed

Wrong type for required_native_memory_bytes (TrainedModelSizeStats class) #2739

svalbuena opened this issue Jul 26, 2024 · 0 comments · Fixed by #2740

Comments

@svalbuena
Copy link
Contributor

svalbuena commented Jul 26, 2024

🐛 Wrong type

The TrainedModelSizeStats class has the wrong type for required_native_memory_bytes, it is marked as integer but should be ByteSize. This is causing the spec to have the wrong type, and the auto-generated clients like the .NET one to always fail when deserializing the response.

Definition

export class TrainedModelSizeStats {
  /** The size of the model in bytes. */
  model_size_bytes: ByteSize
  /** The amount of memory required to load the model in bytes. */
- required_native_memory_bytes: integer
+ required_native_memory_bytes: ByteSize
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants