Allow MemoryStreamFactory to be pluggable #4202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Nov 12, 2019
| /// <summary> | ||
| /// A factory for creating memory streams using instances of <see cref="MemoryStream" /> | ||
| /// </summary> | ||
| public class MemoryStreamFactory : IMemoryStreamFactory | ||
| { | ||
| public static MemoryStreamFactory Default { get; } = new MemoryStreamFactory(); |
There was a problem hiding this comment.
Perhaps we should rename these to .Instance in future?
There was a problem hiding this comment.
I'm happy to roll with .Instance 👍
Mpdreamz
added a commit
that referenced
this pull request
Nov 12, 2019
* Adds versioned benchmarking Allows the benchmarking project to reference Nest.v7 and so makes it easier for us to benchmark proposed changes. * fix compilation errors and temporarily disable dependency on #4202
Mpdreamz
added a commit
that referenced
this pull request
Nov 12, 2019
Mpdreamz
added a commit
that referenced
this pull request
Nov 12, 2019
(cherry picked from commit 0b23cd7)
|
ported to |
Mpdreamz
added a commit
that referenced
this pull request
Nov 12, 2019
* Adds versioned benchmarking (#4206) * Adds versioned benchmarking Allows the benchmarking project to reference Nest.v7 and so makes it easier for us to benchmark proposed changes. * fix compilation errors and temporarily disable dependency on #4202 (cherry picked from commit 16d8a08) * update to nest 8 versioned client for master
russcam
pushed a commit
that referenced
this pull request
Nov 15, 2019
(cherry picked from commit 0b23cd7)
russcam
pushed a commit
that referenced
this pull request
Nov 15, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.