Allow MemoryStreamFactory to be pluggable (#4202)

Author: Mpdreamz

src/Auxiliary/Elasticsearch.Net.VirtualizedCluster/FixedPipelineFactory.cs

@@ -5,7 +5,7 @@ public class FixedPipelineFactory : IRequestPipelineFactory
 		public FixedPipelineFactory(IConnectionConfigurationValues connectionSettings, IDateTimeProvider dateTimeProvider)
 		{
 			DateTimeProvider = dateTimeProvider;
-			MemoryStreamFactory = new MemoryStreamFactory();
+			MemoryStreamFactory = RecyclableMemoryStreamFactory.Default;
 
 			Settings = connectionSettings;
 			Pipeline = Create(Settings, DateTimeProvider, MemoryStreamFactory, new SearchRequestParameters());
@@ -16,7 +16,7 @@ public FixedPipelineFactory(IConnectionConfigurationValues connectionSettings, I
 		public IRequestPipeline Pipeline { get; }
 
 		private IDateTimeProvider DateTimeProvider { get; }
-		private MemoryStreamFactory MemoryStreamFactory { get; }
+		private IMemoryStreamFactory MemoryStreamFactory { get; }
 		private IConnectionConfigurationValues Settings { get; }
 
 		private Transport<IConnectionConfigurationValues> Transport =>

src/Elasticsearch.Net/Configuration/ConnectionConfiguration.cs

@@ -158,6 +158,7 @@ public abstract class ConnectionConfiguration<T> : IConnectionConfigurationValue
 		private bool _sniffOnStartup;
 		private bool _throwExceptions;
 		private bool _transferEncodingChunked;
+		private IMemoryStreamFactory _memoryStreamFactory = RecyclableMemoryStreamFactory.Default;
 
 		private string _userAgent = ConnectionConfiguration.DefaultUserAgent;
 		private Func<HttpMethod, int, bool> _statusCodeToResponseSuccess;
@@ -209,7 +210,7 @@ protected ConnectionConfiguration(IConnectionPool connectionPool, IConnection co
 		TimeSpan? IConnectionConfigurationValues.MaxDeadTimeout => _maxDeadTimeout;
 		int? IConnectionConfigurationValues.MaxRetries => _maxRetries;
 		TimeSpan? IConnectionConfigurationValues.MaxRetryTimeout => _maxRetryTimeout;
-		IMemoryStreamFactory IConnectionConfigurationValues.MemoryStreamFactory { get; } = RecyclableMemoryStreamFactory.Default;
+		IMemoryStreamFactory IConnectionConfigurationValues.MemoryStreamFactory => _memoryStreamFactory;
 
 		Func<Node, bool> IConnectionConfigurationValues.NodePredicate => _nodePredicate;
 		Action<IApiCallDetails> IConnectionConfigurationValues.OnRequestCompleted => _completedRequestHandler;
@@ -557,6 +558,11 @@ public T SkipDeserializationForStatusCodes(params int[] statusCodes) =>
 		/// </summary>
 		public T TransferEncodingChunked(bool transferEncodingChunked = true) => Assign(transferEncodingChunked, (a, v) => a._transferEncodingChunked = v);
 
+		/// <summary>
+		/// The memory stream factory to use, defaults to <see cref="RecyclableMemoryStreamFactory.Default"/>
+		/// </summary>
+		public T MemoryStreamFactory(IMemoryStreamFactory memoryStreamFactory) => Assign(memoryStreamFactory, (a, v) => a._memoryStreamFactory = v);
+
 		protected virtual void DisposeManagedResources()
 		{
 			_connectionPool?.Dispose();

src/Elasticsearch.Net/Providers/MemoryStreamFactory.cs

@@ -2,6 +2,7 @@
 
 namespace Elasticsearch.Net
 {
+	// TODO we use this in some places but its no longer clear to me why need to circumvent RecyclableMemoryStream in some cases
 	/// <summary>
 	/// A factory for creating memory streams using instances of <see cref="MemoryStream" />
 	/// </summary>

src/Elasticsearch.Net/Serialization/ElasticsearchSerializerExtensions.cs

@@ -27,7 +27,7 @@ public static byte[] SerializeToBytes<T>(
 			SerializationFormatting formatting = SerializationFormatting.None
 		)
 		{
-			memoryStreamFactory = memoryStreamFactory ?? RecyclableMemoryStreamFactory.Default;
+			memoryStreamFactory ??= RecyclableMemoryStreamFactory.Default;
 			using (var ms = memoryStreamFactory.Create())
 			{
 				serializer.Serialize(data, ms, formatting);
@@ -58,7 +58,7 @@ public static string SerializeToString<T>(
 			SerializationFormatting formatting = SerializationFormatting.None
 		)
 		{
-			memoryStreamFactory = memoryStreamFactory ?? RecyclableMemoryStreamFactory.Default;
+			memoryStreamFactory ??= RecyclableMemoryStreamFactory.Default;
 			using (var ms = memoryStreamFactory.Create())
 			{
 				serializer.Serialize(data, ms, formatting);