Skip to content

Update tests with ordered properties #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Jan 22, 2020

Brings in diffblue/cbmc#5214

Previously propreties that differed only by name would be in a undefined order. Now they are sorted first by name, then by number. Expected output is updated accordingly.

@thk123 thk123 requested a review from xbauch January 22, 2020 11:33
@thk123 thk123 force-pushed the thk/order-properties branch from ba40074 to fb79be3 Compare January 22, 2020 11:39
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the submodule bump will need updating once diffblue/cbmc#5214 has actually been merged? We need the submodule pointing at cbmc/develop so that everyone/anyone can access the appropriate commit when building gnat2goto. I'll put a blocking review on just until the submodule gets bumped, but other than that, looks good.

@thk123 thk123 force-pushed the thk/order-properties branch from fb79be3 to 166a788 Compare January 22, 2020 13:39
@thk123
Copy link
Contributor Author

thk123 commented Jan 22, 2020

@chrisr-diffblue now pointing at diffblue/cbmc:develop

Copy link
Contributor

@xbauch xbauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, now the submodule points at develop - many thanks.

@thk123
Copy link
Contributor Author

thk123 commented Jan 22, 2020

@chrisr-diffblue @martin-cs I don't have write access. Not sure if I should, but this is ready to merge :)

@chrisr-diffblue
Copy link
Contributor

@thk123 Argh, apologies - I thought I'd added you to the appropriate group, but it turns out I hadn't actually clicked the extra "yes, I really do mean to do this" button. You should now have received an invite from Github.

@thk123 thk123 merged commit 3bbafbe into diffblue:master Jan 22, 2020
@thk123 thk123 deleted the thk/order-properties branch January 22, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants