Fix property sort #5214
Merged
Fix property sort #5214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thk123
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
thk123
pushed a commit
to thk123/gnat2goto
that referenced
this pull request
Jan 22, 2020
hannes-steffenhagen-diffblue
approved these changes
Jan 22, 2020
| const auto right_id_name = right_split.first; | ||
| const auto right_id_number = right_split.second; | ||
|
|
||
| if(left_id_name != right_id_name) |
There was a problem hiding this comment.
FYI this is the same as std::tie(left_id_name, left_id_number) < std::tie(right_id_name, right_id_number).
thk123
force-pushed
the
thk/fix-property-sort
branch
from
dd45c95 to
d34902c
Compare
added 2 commits
January 22, 2020 11:38
Add unit tests demonstrating the fix.
thk123
force-pushed
the
thk/fix-property-sort
branch
from
d34902c to
ac888bb
Compare
thk123
pushed a commit
to thk123/gnat2goto
that referenced
this pull request
Jan 22, 2020
chrisr-diffblue
approved these changes
Jan 22, 2020
allredj
reviewed
Jan 22, 2020
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: ac888bb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/145556447
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
thk123
pushed a commit
to thk123/gnat2goto
that referenced
this pull request
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sorting of properties was unstable if the properties differed only by name. See
dd45c95 to see the fix in isolation.