Skip to content

Process system package #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2019
Merged

Process system package #237

merged 3 commits into from
Jun 7, 2019

Conversation

xbauch
Copy link
Contributor

@xbauch xbauch commented May 17, 2019 •
edited
Loading

Start processing the System package.

hannes-steffenhagen-diffblue
hannes-steffenhagen-diffblue reviewed May 17, 2019
View reviewed changes
gnat2goto/driver/tree_walk.adb Outdated
Package_Symbol.Mode := Intern ("C");
Package_Symbol.Value := Make_Nil (Sloc (N));

Global_Symbol_Table.Insert (Package_Name, Package_Symbol);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we inserting the package into the symbol table? ❓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this refers to #231.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid an initialised symbol in Do_Compilation_Unit

testsuite/gnat2goto/tests/abs/test.out Outdated
@@ -1,7 +1,19 @@
Standard_Error from gnat2goto absolute:
Warning: Multi-language analysis unsupported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this it might be worth to add something like

prove(ignore_lines=[
  'Warning: Multi-language analysis unsupported.'
  ])

which would drop all lines matching some pattern from the output

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about ignoring pragma Import when the calling convention is "Intrinsic" in PR#234

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to use the standard warning mechanism of the gnat front end to generate warning messages and then we could use the pragma Warnings to control reporting.

@chrisr-diffblue chrisr-diffblue changed the title Process system package [depends-on: #231, #236] Process system package [depends-on: #231] Jun 4, 2019
@chrisr-diffblue chrisr-diffblue changed the title Process system package [depends-on: #231] Process system package Jun 7, 2019
@xbauch xbauch mentioned this pull request Jun 7, 2019
Open
tjj2017 and others added 2 commits June 7, 2019 12:56
@tjj2017 @petr-bauch
Start processing system package
d30d80a 
we also do not need to include uname anymore.
@petr-bauch
Update golden results
fb6c7c5
@xbauch xbauch force-pushed the feature/process-system-package branch from 4503eb9 to fb6c7c5 Compare June 7, 2019 12:02
@xbauch xbauch removed the draft label Jun 7, 2019
@xbauch xbauch marked this pull request as ready for review June 7, 2019 12:03
chrisr-diffblue
chrisr-diffblue approved these changes Jun 7, 2019
View reviewed changes
@petr-bauch
Address review comments
0805991 
will be squashed.
NlightNFotis
NlightNFotis reviewed Jun 7, 2019
View reviewed changes
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand how the commit message has anything to do with what's going on in the first commit. Can someone explain it to me?

@xbauch
Copy link
Contributor Author

xbauch commented Jun 7, 2019

@NlightNFotis before in do_withed_spec we ignored two kinds of packages
1: those with defining identity being Standard_Standard
2: those whose name had prefix system
this commit stops ignoring the system packages and runs the same processing on them (of the withed spec) as for user-defined packages.

hannes-steffenhagen-diffblue
hannes-steffenhagen-diffblue approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get it but OK

NlightNFotis
NlightNFotis approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xbauch xbauch merged commit 98fd6aa into diffblue:master Jun 7, 2019
@xbauch xbauch mentioned this pull request Jun 7, 2019
Closed
@xbauch xbauch deleted the feature/process-system-package branch June 10, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjj2017 tjj2017 tjj2017 left review comments

@NlightNFotis NlightNFotis NlightNFotis approved these changes

@chrisr-diffblue chrisr-diffblue chrisr-diffblue approved these changes

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue approved these changes

Assignees

@NlightNFotis NlightNFotis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xbauch @NlightNFotis @chrisr-diffblue @tjj2017 @hannes-steffenhagen-diffblue @petr-bauch