Skip to content

Ignore warnings in regression tests #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

xbauch
Copy link
Contributor

@xbauch xbauch commented May 17, 2019

Includes a regression test that generates a warning.

Reasoning: System package contains export/import pragmas that we want to ignore
but now about. Our regression test was sensitive to all gnat2goto output,
including warnings.

Includes a regression test that generates a warning.

Reasoning: System package contains export/import pragmas that we want to ignore
but now about. Our regression test was sensitive to all gnat2goto output,
including warnings.
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's a small typo in the commit message (now was supposed to be know?). Also, I feel like this should be documented somewhere else as well.

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a very blunt instrument at the moment, because it basically filters out all warnings - but we probably want to know if certain warnings suddenly appear.... I also can't see where we would see these warnings in CI?

Can we not just update all the test.out files to include the warnings that we know about? I know that would be a pain to maintain, but it means there is a record (in the commit history) of what warnings we are aware of, and any unexpected new warnings will show up.

@tjj2017
Copy link
Collaborator

tjj2017 commented May 29, 2019

The warnings are generated by the Import pragmas. A warning is given by gnat2goto that non Ada languages are not supported. However, in the case of the Import pragmas in System and its child packages, the calling convention is "intrinsic" which indicates it is a subprogram built into the compiler (see ALRM 6.3.1) and as such I think can be safely ignored without issuing a warning.

I have a draft modification which does this but have not committed it yet. I wanted to get other people's views.

@xbauch xbauch added the invalid label Jun 7, 2019
@xbauch
Copy link
Contributor Author

xbauch commented Jun 7, 2019

Unnecessary now that #237 is merged (and does not produce any warnings).

@xbauch xbauch closed this Jun 7, 2019
@xbauch xbauch deleted the feature/ignore-warnings-regression branch June 10, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants